Re: [Buildroot] [PATCH v2 1/1] package/go: make pre-built compiler provide target support too

[yann.morin@orange.com]

Florian, All,

On 2025-07-14 16:52 +0200, Florian Larysch spake thusly:
> All Go packages must depend on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS,
> which ensures that we do have a Go compiler available for that target.
> 
> BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS is currently restricted to the
> availability of a full host Go compiler bootstrap. However, there are
> architectures like AArch64 for which a full bootstrap is not supported.
> 
> Thus, currently, on an AArch64 host, we can't build Go packages (for
> target or host), because we can't bootstrap a Go compiler.
> 
> However, note that a single Go compiler can generate code for all the
> architectures supported by Go and for some host architectures, there are
> pre-built toolchains available. When host-go-bin was added in commit
> 7b2a164b7460 ("package/go/go-bin: new host-go provider"), the host
> dependency was properly accounted for: It is already possible to build
> host-go packages with go-bin. However, the fact that a Go compiler, in
> addition to its native target, can also generate code for all supported
> architectures, was missed at the time.
> 
> Thus, we can fix this problem by relaxing the condition under which
> BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS is set to allowing go-bin
> along with go-bootstrap. This allows a situation where the host can't
> bootstrap, but for which there is a pre-built toolchain to build Go
> packages for a supported target.
> 
> Signed-off-by: Florian Larysch <fl@n621.de>
> Cc: Yann E. MORIN <yann.morin@orange.com>
> Cc: Romain Naour <romain.naour@smile.fr>

Reviewed-by: Yann E. MORIN <yann.morin@orange.com>

Thanks for the respin!

Regards,
Yann E. MORIN.

> ---
> v1->v2:
>  - Reworded commit message after discussion with Romain and Yann.
> 
>  package/go/Config.in.host | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/go/Config.in.host b/package/go/Config.in.host
> index 7e354b3298..a42e37f90b 100644
> --- a/package/go/Config.in.host
> +++ b/package/go/Config.in.host
> @@ -2,7 +2,7 @@
>  config BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	bool
>  	default y
> -	depends on BR2_PACKAGE_HOST_GO_BOOTSTRAP_STAGE3_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_HOST_GO_BOOTSTRAP_STAGE3_ARCH_SUPPORTS || BR2_PACKAGE_HOST_GO_BIN_HOST_ARCH_SUPPORTS
>  	# See https://go.dev/doc/install/source#environment
>  	# See src/go/build/syslist.go for the list of supported architectures
>  	depends on (BR2_arm && BR2_TOOLCHAIN_SUPPORTS_PIE) || BR2_aarch64 \
> -- 
> 2.49.0
> 

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot