From: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
To: Andreas Ziegler <br025@umbiko.net>
Cc: buildroot@buildroot.org, Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings
Date: Tue, 20 Jan 2026 16:00:41 +0100 [thread overview]
Message-ID: <aW-Ymbk7AVbk18gB@probook> (raw)
In-Reply-To: <20260120090726.43100-1-br025@umbiko.net>
On Tue, Jan 20, 2026 at 10:07:24AM +0100, Andreas Ziegler wrote:
> Shellcheck commit 4f81dbe [1] added SC2329 (function is never invoked)
> and fixed SC2317 (Command appears to be unreachable).
>
> [1] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565
>
> $ shellcheck package/mpd/S95mpd
>
> In package/mpd/S95mpd line 13:
> start() {
> ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
>
> Change shellcheck exception number in header of S95mpd.
>
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
> ---
Looks good,
Reviewed-by: J. Neuschäfer <j.neuschaefer@gmx.net>
Thanks!
> package/mpd/S95mpd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mpd/S95mpd b/package/mpd/S95mpd
> index ac971e04a2..481ee70a20 100644
> --- a/package/mpd/S95mpd
> +++ b/package/mpd/S95mpd
> @@ -2,7 +2,7 @@
> #
> # S95mpd Starts Music Player daemon.
> #
> -# shellcheck disable=SC2317 # functions are called via variable
> +# shellcheck disable=SC2329 # functions are called via variable
>
> DAEMON="mpd"
> PIDFILE="/var/run/$DAEMON.pid"
> --
> 2.51.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-01-20 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:07 [Buildroot] [PATCH 1/1] package/mpd: fix shellcheck warnings Andreas Ziegler
2026-01-20 15:00 ` J. Neuschäfer via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-Ymbk7AVbk18gB@probook \
--to=buildroot@buildroot.org \
--cc=br025@umbiko.net \
--cc=fiona.klute@gmx.de \
--cc=j.neuschaefer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox