From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vincent Jardin <vjardin@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] package/sysrepo: fix build on riscv32
Date: Sun, 18 Jan 2026 22:51:04 +0100 [thread overview]
Message-ID: <aW1VgW5jNJI5Gh_6@windsurf> (raw)
In-Reply-To: <20260118213120.69615-2-vjardin@free.fr>
Hello Vincent,
On Sun, Jan 18, 2026 at 10:31:20PM +0100, Vincent Jardin wrote:
> +# riscv32 glibc doesn't define SYS_futex (only SYS_futex_time64)
> +# Use pthread-based condition variables instead of futex
> +# https://github.com/sysrepo/sysrepo/issues/3346
> +ifeq ($(BR2_RISCV_32),y)
> +SYSREPO_CONF_OPTS += -DSR_COND_IMPL=sr_cond_pthread
> +endif
Thanks for the fix. However, since sysrepo is maintained *and* using a
reasonable build system (CMake), the build system should test the
availability of SYS_futex, and only use it if available, without
requiring the user to know about these "gory" details. After all, this
is what CMakeLists.txt tests are made for. Could you cook something
like this, or check with upstream?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-01-18 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 17:54 [Buildroot] [PATCH v1 0/2] Add python-libyang and python-sysrepo packages Vincent Jardin via buildroot
2026-01-07 17:54 ` [Buildroot] [PATCH v1 1/2] package/python-libyang: new package Vincent Jardin via buildroot
2026-01-07 22:40 ` Thomas Petazzoni via buildroot
2026-01-07 17:54 ` [Buildroot] [PATCH v1 2/2] package/python-sysrepo: " Vincent Jardin via buildroot
2026-01-07 22:45 ` Thomas Petazzoni via buildroot
2026-01-18 21:31 ` [Buildroot] [PATCH v1 0/1] package/sysrepo: fix build on riscv32 Vincent Jardin via buildroot
2026-01-18 21:31 ` [Buildroot] [PATCH v1 1/1] " Vincent Jardin via buildroot
2026-01-18 21:51 ` Thomas Petazzoni via buildroot [this message]
2026-02-17 16:00 ` [Buildroot] [PATCH v2 " Vincent Cruz
2026-02-18 12:31 ` mooz
2026-01-18 21:51 ` [Buildroot] [PATCH v1 0/1] " Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW1VgW5jNJI5Gh_6@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox