Re: [Buildroot] [PATCH 2/4] package/util-linux: fix nommu build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sat, Dec 20, 2025 at 06:06:21PM +0100, Bernd Kuhls wrote:
> libuuid/src/gen_uuid.c: In function 'uuid_generate_time_generic':
> libuuid/src/gen_uuid.c:629:17: error: implicit declaration of function 'pthread_atfork';
>  did you mean 'pthread_join'? [-Wimplicit-function-declaration]
>   629 |                 pthread_atfork(NULL, NULL, reset_uuidd_cache);

Since when is this happening?

> +# pthread support uses pthread_atfork, which is not available on nommu
> +ifneq ($(BR2_USE_MMU),y)
> +UTIL_LINUX_CONF_ENV += ac_cv_lib_pthread_pthread_atfork=no
> +endif

This is also the wrong fix, it should be fixed in an upstream
compatible way. The failure doesn't make sense to me. Indeed, the
configure.ac contains:

AC_CHECK_LIB([pthread], [pthread_atfork], [
        PTHREAD_LIBS="-lpthread"
        AC_DEFINE([HAVE_LIBPTHREAD], [1], [Define if libpthred exist])
])

So HAVE_LIBPTHREAD should only be defined if pthread_atfork() is found
in libpthread.

And the only pthread_atfork() call is within an #ifdef HAVE_LIBPTHREAD
condition:

#ifdef HAVE_LIBPTHREAD
	static volatile sig_atomic_t atfork_registered;
	time_t	now;

	if (!atfork_registered) {
		pthread_atfork(NULL, NULL, reset_uuidd_cache);
		atfork_registered = 1;
	}

So, some investigation is needed to understand why this configure.ac +
conditional compilation logic doesn't work as it should.

But isn't this something Julien already had a look at a long time ago?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot