Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/swupdate: fix build failure due to missing include
Date: Tue, 3 Feb 2026 17:16:24 +0100	[thread overview]
Message-ID: <aYIe1pqsEBM8J9Qm@windsurf> (raw)
In-Reply-To: <20251125145024.602672-1-giulio.benetti@benettiengineering.com>

Hello,

On Tue, Nov 25, 2025 at 03:50:24PM +0100, Giulio Benetti wrote:
> Add local patch upstreamed to fix build failure due to missing unistd.h
> include.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

I'm rather confused, because we have been using swupdate 2025.05 in
Buildroot since commit d5826736d5aa63eb818a5d20338b7b698f66dad7, which
was merged in May 2025, and this version already includes <unistd.h>
in network_ipc-if.c.

So I'm rather confused. Also, I couldn't reproduce the issue, building
swupdate with a musl toolchain.

Could you clarify? Also keep in mind that when fixing issues we need
to indicate since when the issue exists so that our dear LTS
maintainers can understand whether the fix needs to be backported or
not.

I'll mark the patch as "Not Applicable", but feel free to send a new
iteration with more details if you find out that the patch is actually
still needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-02-03 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 14:50 [Buildroot] [PATCH] package/swupdate: fix build failure due to missing include Giulio Benetti
2026-02-03 16:16 ` Thomas Petazzoni via buildroot [this message]
2026-02-10 16:19   ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYIe1pqsEBM8J9Qm@windsurf \
    --to=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox