Re: [Buildroot] [PATCHv2 1/1] package/cjson: add a patch to allow cross-compilation with sysroot.

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Guillaume,

Sorry for the long delay in getting back to you.

On Mon, Apr 28, 2025 at 05:12:48AM -0400, Guillaume Chaye wrote:
> From: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
> 
> The current generated cJSONConfig.cmake holds hard coded path of libraries and makes it impossible to use in SDKs.

Could you provide some more details here? Indeed, normally hardcoded
paths in text files are properly replaced by our relocate-sdk.sh
scripts. Are you sure we're talking about hardcoded paths, or paths
that are just invalid in the first place? I did a build of cjson
without your patch, and saw some /usr/include in
cJSONConfig.cmake. Are these the problemtic paths?

> Use CMakePackageConfigHelpers and @PACKAGE_INIT@ to make them suit for real environment dynamically.

The problem with your proposal is that the upstream submission was
made over 2 years ago, has received no interest/feedback from
upstream, but makes some fairly substantial changes to CMakeLists.txt
that would make updating to later versions cJSON quite a lot more
difficult.

Could you push further the topic upstream, so that we have something
that is accepted upstream, and that we can safely backport in
Buildroot?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot