From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/which: fix build with musl
Date: Sun, 8 Mar 2026 20:44:10 +0100 [thread overview]
Message-ID: <aa3RSS1ySofI-yAO@windsurf> (raw)
In-Reply-To: <20260308103213.1117775-1-chakrabortyshubham66@gmail.com>
On Sun, Mar 08, 2026 at 04:02:12PM +0530, Shubham Chakraborty wrote:
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
> package/which/0001-fix-getopt-prototype.patch | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 package/which/0001-fix-getopt-prototype.patch
>
> diff --git a/package/which/0001-fix-getopt-prototype.patch b/package/which/0001-fix-getopt-prototype.patch
> new file mode 100644
> index 0000000000..29401b0f53
> --- /dev/null
> +++ b/package/which/0001-fix-getopt-prototype.patch
Patches should have a description (with a title, followed by one or
several paragraphs with details), plus a Signed-off-by line.
Also, patches should preferably be formatted using "git format-patch".
> @@ -0,0 +1,11 @@
> +--- a/getopt.h
> ++++ b/getopt.h
> +@@ -102,7 +102,7 @@
> + errors, only prototype getopt for the GNU C library. */
> + extern int getopt(int argc, char *const *argv, const char *shortopts);
> + #else /* not __GNU_LIBRARY__ */
> +-extern int getopt();
> ++extern int getopt(int argc, char *const *argv, const char *shortopts);
I really don't see how this can be musl related. Much more likely to
be gcc-version related.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-03-08 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 10:32 [Buildroot] [PATCH 1/2] package/which: fix build with musl Shubham Chakraborty
2026-03-08 10:32 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself as maintainer of package/which Shubham Chakraborty
2026-03-08 19:45 ` Thomas Petazzoni via buildroot
2026-03-08 19:44 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa3RSS1ySofI-yAO@windsurf \
--to=buildroot@buildroot.org \
--cc=chakrabortyshubham66@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox