[Buildroot] [PATCH 1/2] package/which: fix build with musl

[Buildroot] [PATCH 1/2] package/which: fix build with musl

[Shubham Chakraborty]

Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
 package/which/0001-fix-getopt-prototype.patch | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 package/which/0001-fix-getopt-prototype.patch

diff --git a/package/which/0001-fix-getopt-prototype.patch b/package/which/0001-fix-getopt-prototype.patch
new file mode 100644
index 0000000000..29401b0f53
--- /dev/null
+++ b/package/which/0001-fix-getopt-prototype.patch
@@ -0,0 +1,11 @@
+--- a/getopt.h
++++ b/getopt.h
+@@ -102,7 +102,7 @@
+    errors, only prototype getopt for the GNU C library.  */
+ extern int getopt(int argc, char *const *argv, const char *shortopts);
+ #else  /* not __GNU_LIBRARY__ */
+-extern int getopt();
++extern int getopt(int argc, char *const *argv, const char *shortopts);
+ #endif /* __GNU_LIBRARY__ */
+ extern int getopt_long(int argc, char *const *argv, const char *shortopts, const struct option *longopts, int *longind);
+ extern int getopt_long_only(int argc, char *const *argv, const char *shortopts, const struct option *longopts,
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] DEVELOPERS: add myself as maintainer of package/which

[Shubham Chakraborty]

Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
 DEVELOPERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index 835be1f6a3..f3ae83e53c 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -3058,6 +3058,9 @@ F:	package/tunctl/
 F:	package/ubus/
 F:	package/wolfssl/
 
+N:      Shubham Chakraborty <chakrabortyshubham66@gmail.com>
+F:      package/which
+
 N:	Simon Dawson <spdawson@gmail.com>
 F:	boot/at91bootstrap3/
 F:	package/cppzmq/
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/which: fix build with musl

[Thomas Petazzoni via buildroot]

On Sun, Mar 08, 2026 at 04:02:12PM +0530, Shubham Chakraborty wrote:
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>  package/which/0001-fix-getopt-prototype.patch | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 package/which/0001-fix-getopt-prototype.patch
> 
> diff --git a/package/which/0001-fix-getopt-prototype.patch b/package/which/0001-fix-getopt-prototype.patch
> new file mode 100644
> index 0000000000..29401b0f53
> --- /dev/null
> +++ b/package/which/0001-fix-getopt-prototype.patch

Patches should have a description (with a title, followed by one or
several paragraphs with details), plus a Signed-off-by line.

Also, patches should preferably be formatted using "git format-patch".

> @@ -0,0 +1,11 @@
> +--- a/getopt.h
> ++++ b/getopt.h
> +@@ -102,7 +102,7 @@
> +    errors, only prototype getopt for the GNU C library.  */
> + extern int getopt(int argc, char *const *argv, const char *shortopts);
> + #else  /* not __GNU_LIBRARY__ */
> +-extern int getopt();
> ++extern int getopt(int argc, char *const *argv, const char *shortopts);

I really don't see how this can be musl related. Much more likely to
be gcc-version related.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] DEVELOPERS: add myself as maintainer of package/which

[Thomas Petazzoni via buildroot]

On Sun, Mar 08, 2026 at 04:02:13PM +0530, Shubham Chakraborty wrote:
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>  DEVELOPERS | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 835be1f6a3..f3ae83e53c 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3058,6 +3058,9 @@ F:	package/tunctl/
>  F:	package/ubus/
>  F:	package/wolfssl/
>  
> +N:      Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> +F:      package/which

Indentation is done using tabs in this file.

Also, final slash in package/which/ (to be consistent with the rest of
the file).

Thanks!

Thomas 
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot