Re: [Buildroot] [PATCH 1/1] package/libcamera: update source URL

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Laurent, Kieran,

On 09/07/2026 15:23, Laurent Pinchart wrote:
> On Thu, Jul 09, 2026 at 11:41:03AM +0100, Kieran Bingham wrote:
>> Quoting Laurent Pinchart (2026-07-09 11:26:24)
>> > On Thu, Jul 09, 2026 at 11:19:58AM +0100, Kieran Bingham wrote:
>> > > Quoting Laurent Pinchart (2026-07-08 23:35:32)
>> > > > libcamera has moved for a while now to gitlab.freedesktop.org. The
>> > > > mirror on git.linuxtv.org is still active, but it isn't the canonical
>> > > > repository and has less bandwidth than freedesktop.org. Switch the
>> > > > libcamera source URL to gitlab.freedesktop.org.
>> > > >
>> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> > > > ---
>> > > >  package/libcamera/libcamera.mk | 2 +-
>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >
>> > > > diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
>> > > > index 945207888bab..ba7510daf8e1 100644
>> > > > --- a/package/libcamera/libcamera.mk
>> > > > +++ b/package/libcamera/libcamera.mk
>> > > > @@ -4,7 +4,7 @@
>> > > >  #
>> > > >  ################################################################################
>> > > >
>> > > > -LIBCAMERA_SITE = https://git.linuxtv.org/libcamera.git
>> > > > +LIBCAMERA_SITE = https://gitlab.freedesktop.org/camera/libcamera.git/
>> > >
>> > > Why the trailing slash?
>> > >
>> > > Though I've just checked and :
>> > >  git clone https://gitlab.freedesktop.org/camera/libcamera.git/
>> > >
>> > > works as expected,
>> > >
>> > > Viewing the webpage, drops the .git but cloneing without .git reports
>> > > the following:
>> > >
>> > > kbingham@Monstersaurus:/tmp$ git clone https://gitlab.freedesktop.org/camera/libcamera
>> > > Cloning into 'libcamera'...
>> > > warning: redirecting to https://gitlab.freedesktop.org/camera/libcamera.git/
>> > >
>> > > Which has the trailing slash so :
>> >
>> > That's exactly why I added a trailing slash :-)
>> 
>> The web interface does however report this as the URL:
>> 
>>  https://gitlab.freedesktop.org/camera/libcamera.git
>> 
>> without the slash, and cloning that doesn't redirect to one /with/ a
>> slash.
>> 
>> Personally I wouldn't add it - but it's harmless either way.
> 
> I'm fine dropping it. Can this be done when applying the patch ? I can
> send a v2 otherwise.

I removed the trailing slash and applied to master, thanks.

We usually don't put those in Buildroot. Also, it will remain
consistent with other packages using gitlab.freedesktop.org
(piglit, waffle).

>> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>> > >
>> > > >  LIBCAMERA_VERSION = v0.7.1
>> > > >  LIBCAMERA_SITE_METHOD = git
>> > > >  LIBCAMERA_DEPENDENCIES = \
>> > > >
>> > > > base-commit: 6854ee9aa3826d5036a7d3cc19056d43c0452320
> 
> --
> Regards,
> 
> Laurent Pinchart

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot