Re: [Buildroot] [PATCH] package: Add drm_info

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: buildroot@buildroot.org,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	 Eric Le Bihan <eric.le.bihan.dev@free.fr>
Subject: Re: [Buildroot] [PATCH] package: Add drm_info
Date: Sun, 15 Mar 2026 17:34:38 +0100	[thread overview]
Message-ID: <abbeWoojTqlSCJwr@windsurf> (raw)
In-Reply-To: <20260312111331.391639-1-kory.maincent@bootlin.com>

Hello Kory,

Thanks for the patch.

The commit title should be:

    package/drm-info: new package

On Thu, Mar 12, 2026 at 12:13:30PM +0100, Kory Maincent via buildroot wrote:
> drm_info is a small utility to dump info about DRM devices.
> 
> Link: https://gitlab.freedesktop.org/emersion/drm_info
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>  package/Config.in                             |  1 +
>  ...0001-meson.build-Fix-Buildroot-build.patch | 34 +++++++++++++++++++
>  package/drm_info/Config.in                    |  8 +++++
>  package/drm_info/drm_info.hash                |  5 +++
>  package/drm_info/drm_info.mk                  | 15 ++++++++
>  5 files changed, 63 insertions(+)

The package should be named drm-info, not drm_info.

Also, please add an entry in the DEVELOPERS file.

> diff --git a/package/drm_info/0001-meson.build-Fix-Buildroot-build.patch b/package/drm_info/0001-meson.build-Fix-Buildroot-build.patch
> new file mode 100644
> index 0000000000..b709ab8a1f
> --- /dev/null
> +++ b/package/drm_info/0001-meson.build-Fix-Buildroot-build.patch
> @@ -0,0 +1,34 @@
> +From 785525a74878bdf688c5466d83e193e207abed6a Mon Sep 17 00:00:00 2001
> +From: Kory Maincent <kory.maincent@bootlin.com>
> +Date: Wed, 11 Mar 2026 19:03:46 +0100
> +Subject: [PATCH] meson.build: Fix Buildroot build
> +
> +In cross compilation case pc_sysrootdir variable contains the sysroot path,
> +but includedir from pkgconfig already contains the full absolute path
> +(sysroot + /usr/include), so concatenating them double the sysroot prefix.
> +
> +The fix removes pc_sysrootdir + so includedir is used directly, which
> +already points to the correct absolute path on the filesystem.
> +
> +Upstream: N/A

Clearly doing cross-compilation properly with meson is possible. So an
upstreamable patch must be possible for this. I think using
pc_sysrootdir here is incorrect, but I haven't checked thoroughly. But
in any case, this is not a "fix Buildroot build" patch, as this issue
is unrelated to Buildroot, any other cross-compilation scenario would
encounter the same issue. This means a patch must be submitted
upstream.

> diff --git a/package/drm_info/Config.in b/package/drm_info/Config.in
> new file mode 100644
> index 0000000000..a664485d03
> --- /dev/null
> +++ b/package/drm_info/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_DRM_INFO
> +	bool "drm_info"

	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm

must be added here.

> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_JSON_C
> +	help
> +	  Small utility to dump info about DRM devices.
> +
> +	  https://gitlab.freedesktop.org/emersion/drm_info

And:

comment "drm-info needs a toolchain w/ threads"
	depends on !BR2_TOOLCHAIN_HAS_THREADS

> diff --git a/package/drm_info/drm_info.mk b/package/drm_info/drm_info.mk
> new file mode 100644
> index 0000000000..dd2698247b
> --- /dev/null
> +++ b/package/drm_info/drm_info.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# drm_info

drm-info

> +#
> +################################################################################

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot