From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 5 v3] manual package list: add symbol name in table
Date: Fri, 03 Jan 2014 17:02:52 +0100 [thread overview]
Message-ID: <aede5cd8614f3dd67a21.1388764972@argentina> (raw)
In-Reply-To: <patchbomb.1388764969@argentina>
Particularly in the list of deprecated packages, it is not always clear what
the entry name refers to. For example, for squashfs3 rootfs support, the
string is simply "3.x". Likewise for the flex target binary: "Install tool
in the target".
To clarify the entries, add the actual symbol name (BR2_xxx) in the table.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
support/scripts/gen-manual-lists.py | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/support/scripts/gen-manual-lists.py b/support/scripts/gen-manual-lists.py
--- a/support/scripts/gen-manual-lists.py
+++ b/support/scripts/gen-manual-lists.py
@@ -124,20 +124,20 @@ def format_asciidoc_table(root, get_labe
:param sub_menu: Output the column with the sub-menu path
"""
- def _format_entry(item, parents, sub_menu):
+ def _format_entry(item, symbol, parents, sub_menu):
""" Format an asciidoc table entry.
"""
if sub_menu:
- return "| {0:<40} <| {1}\n".format(item, " -> ".join(parents))
+ return "| {0:<40} <| {1} | {2}\n".format(item, symbol, " -> ".join(parents))
else:
- return "| {0:<40}\n".format(item)
+ return "| {0:<40} | {1}\n".format(item, symbol)
lines = []
for item in get_symbol_subset(root, filter_func):
if not item.is_symbol() or not item.prompts:
continue
loc = get_symbol_parents(item, root, enable_choice=enable_choice)
- lines.append(_format_entry(get_label_func(item), loc, sub_menu))
+ lines.append(_format_entry(get_label_func(item), item.get_name(), loc, sub_menu))
if sorted:
lines.sort(key=lambda x: x.lower())
if hasattr(root, "get_title"):
@@ -147,16 +147,17 @@ def format_asciidoc_table(root, get_labe
loc_label = ["Location"]
if not item_label:
item_label = "Items"
+ symbol_label = "Symbol"
table = ":halign: center\n\n"
if sub_menu:
width = "100%"
- columns = "^1,4"
+ columns = "^1,1,4"
else:
- width = "30%"
- columns = "^1"
+ width = "60%"
+ columns = "^1,1"
table = "[width=\"{0}\",cols=\"{1}\",options=\"header\"]\n".format(width, columns)
table += "|===================================================\n"
- table += _format_entry(item_label, loc_label, sub_menu)
+ table += _format_entry(item_label, symbol_label, loc_label, sub_menu)
table += "\n" + "".join(lines) + "\n"
table += "|===================================================\n"
return table
next prev parent reply other threads:[~2014-01-03 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 16:02 [Buildroot] [PATCH 0 of 5 v3] Introduce new deprecation symbols, and remove squashfs3/ttcp Thomas De Schampheleire
2014-01-03 16:02 ` [Buildroot] [PATCH 1 of 5 v3] deprecated handling: introduce BR2_DEPRECATED_SINCE_xxxx_xx Thomas De Schampheleire
2014-01-04 8:20 ` Thomas De Schampheleire
2014-01-04 8:24 ` Thomas De Schampheleire
2014-01-10 6:51 ` Arnout Vandecappelle
2014-01-10 14:11 ` Peter Korsgaard
2014-01-03 16:02 ` [Buildroot] [PATCH 2 of 5 v3] manual: clarify handling of deprecated features Thomas De Schampheleire
2014-01-03 16:02 ` Thomas De Schampheleire [this message]
2014-01-10 6:44 ` [Buildroot] [PATCH 3 of 5 v3] manual package list: add symbol name in table Arnout Vandecappelle
2014-01-03 16:02 ` [Buildroot] [PATCH 4 of 5 v3] squashfs3: remove deprecated package/rootfs Thomas De Schampheleire
2014-01-10 6:55 ` Arnout Vandecappelle
2014-01-10 14:14 ` Peter Korsgaard
2014-01-03 16:02 ` [Buildroot] [PATCH 5 of 5 v3] ttcp: remove deprecated package Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aede5cd8614f3dd67a21.1388764972@argentina \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox