Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies
Date: Mon, 17 Apr 2017 18:50:57 +0200	[thread overview]
Message-ID: <afeadabf-41c8-d136-dc75-5d497457a467@gmail.com> (raw)
In-Reply-To: <20170417164401.24236-1-yann.morin.1998@free.fr>

Hi Yann, All,

Le 17/04/2017 ? 18:44, Yann E. MORIN a ?crit :
> BR2_ARM_CPU_HAS_ARM already embeddeds the fact that this is an ARM chip,
> so (BR2_arm || BR2_armeb) is forcibly true when BR2_ARM_CPU_HAS_ARM is.
> 
> In other words, BR2_ARM_CPU_HAS_ARM can't be true unless either BR2_arm
> or BR2_armeb itslef is true.
> 
> Simplify the logic accordingly.

The same simplification can be done in package/boost/Config.in.

Acked-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/libunwind/Config.in | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/package/libunwind/Config.in b/package/libunwind/Config.in
> index 9007ce51c2..2003e96518 100644
> --- a/package/libunwind/Config.in
> +++ b/package/libunwind/Config.in
> @@ -10,16 +10,13 @@
>  config BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
>  	bool
>  	default y if BR2_TOOLCHAIN_USES_GLIBC && \
> -		(((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> -		 BR2_mips || BR2_mipsel || BR2_mips64 || \
> +		(BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || BR2_mips64 || \
>  		 BR2_mips64el || BR2_powerpc || BR2_sh || BR2_i386 || BR2_x86_64)
>  	default y if BR2_TOOLCHAIN_USES_UCLIBC && \
> -		(((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> -		 BR2_mips || BR2_mipsel || \
> +		(BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || \
>  		 BR2_mips64 || BR2_mips64el || BR2_x86_64)
>  	default y if BR2_TOOLCHAIN_USES_MUSL && \
> -		(((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> -		 BR2_i386 || BR2_x86_64)
> +		(BR2_ARM_CPU_HAS_ARM || BR2_i386 || BR2_x86_64)
>  
>  config BR2_PACKAGE_LIBUNWIND
>  	bool "libunwind"
> 

  reply	other threads:[~2017-04-17 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 16:44 [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies Yann E. MORIN
2017-04-17 16:50 ` Romain Naour [this message]
2017-05-04 21:22 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afeadabf-41c8-d136-dc75-5d497457a467@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox