Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Titouan Christophe <titouan.christophe@mind.be>
Cc: yann.morin@orange.com, ps.report@gmx.net, petr.vorel@gmail.com,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 7/9] package/openssl: move libopenssl/libressl/.br2-external.in.openssl source statements outside of the choice
Date: Mon, 1 Jun 2026 09:51:15 +0200	[thread overview]
Message-ID: <ah05yyYArQrKGVsR@windsurf> (raw)
In-Reply-To: <e365b141-28f7-42d9-8d02-aeb68191e07a@mind.be>

Hello,

On Mon, Jun 01, 2026 at 08:50:25AM +0200, Titouan Christophe wrote:

> On 31/05/26 18:22, Thomas Petazzoni wrote:
> > On Sun, May 31, 2026 at 05:35:51PM +0200, Titouan Christophe wrote:
> > > +config BR2_PACKAGE_OPENSSL_EXTERNAL
> > > +        bool "from an external tree"
> > > +        depends on "$(BR2_EXTERNAL)" != ""
> > Hu? What is this thing?
> Not exactly sure for this particular entry (maybe you still remember that
> part @Peter Seiderer ?). Indeed, if I revert that particular change
> everything still works as expected. However, reverting either the libressl
> or libopenssl trigger the issue.
> 
> What I can tell for sure is that the libressl & libopenssl changes are
> required because a choice can no longer contain ifs, and the included file
> have some; hence the trickery to move them out of the choice.
> 
> I don't know about a publicly available br2-external that provides openssl,
> but if you have some I'd be glad to look further into that.

I don't have one, but it should be trivial to create a fake/dummy one,
to make sure this continues to work. Or maybe we have a runtime test
for this? (And if not we should have one!)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-06-01  7:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31 15:35 [Buildroot] [PATCH v4 0/9] Update kconfig infrastructure to Linux 6.9 Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 1/9] Makefile: always use a base config file for defconfig Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 2/9] support/kconfig: fix invalid filenames in patch 23 Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 3/9] Config.in: do not expand TOPDIR, BASE_DIR and CONFIG_DIR Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 4/9] toolchain-external: do not expand ARCH Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 6/9] support/kconfig: reference environment variables directly (remove 'option env=') Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 7/9] package/openssl: move libopenssl/libressl/.br2-external.in.openssl source statements outside of the choice Titouan Christophe via buildroot
2026-05-31 16:22   ` Thomas Petazzoni via buildroot
2026-06-01  6:50     ` Titouan Christophe via buildroot
2026-06-01  7:51       ` Thomas Petazzoni via buildroot [this message]
2026-05-31 15:35 ` [Buildroot] [PATCH v4 8/9] docs: update the Buildroot manual for kconfig variables expansion Titouan Christophe via buildroot
2026-05-31 15:35 ` [Buildroot] [PATCH v4 9/9] Makefile: add new target "yellowconfig" based on kconfiglib Titouan Christophe via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah05yyYArQrKGVsR@windsurf \
    --to=buildroot@buildroot.org \
    --cc=petr.vorel@gmail.com \
    --cc=ps.report@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=titouan.christophe@mind.be \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox