From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Jesse Van Gavere <jesseevg@gmail.com>,
Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency
Date: Fri, 29 May 2026 21:13:38 +0200 [thread overview]
Message-ID: <ahnlP2lj_zl11I3b@windsurf> (raw)
In-Reply-To: <ahnci7WYFV3NQ8rS@windsurf>
On Fri, May 29, 2026 at 08:37:32PM +0200, Thomas Petazzoni wrote:
> Hello Bernd,
>
> On Fri, May 01, 2026 at 08:34:17PM +0200, Bernd Kuhls wrote:
> > qt5serialport is only needed when GPS support is enabled:
> > https://github.com/Stellarium/stellarium/blob/v26.1/CMakeLists.txt#L632
>
> Well, it seems like you're pointing to code that shows your statement
> is not correct:
>
> IF(USE_PLUGIN_TELESCOPECONTROL OR ENABLE_GPS)
> FIND_PACKAGE(Qt${QT_VERSION_MAJOR} COMPONENTS SerialPort REQUIRED)
> ENDIF()
>
> So Qt is used when gps support is enabled *OR* when the telescope
> control plugin is enabled, and this plugin is apparently enabled by
> default.
On this I am wrong, we disable building the telescope control plugin:
-DUSE_PLUGIN_TELESCOPECONTROL=OFF \
> I don't understand the "wrong order of dependencies". Is this fixing a
> bug?
Still interested by some feedback on this.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-05-29 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 18:34 [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 2/5] package/stellarium: bump version to 26.1 Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 3/5] package/stellarium: add extra downloads Bernd Kuhls
2026-05-29 21:20 ` Thomas Petazzoni via buildroot
2026-05-01 18:34 ` [Buildroot] [PATCH 4/5] package/qt6/qt6positioning: new package Bernd Kuhls
2026-05-01 18:34 ` [Buildroot] [PATCH 5/5] package/stellarium: allow build with qt6 Bernd Kuhls
2026-05-29 18:37 ` [Buildroot] [PATCH 1/5] package/stellarium: fix qt5serialport dependency Thomas Petazzoni via buildroot
2026-05-29 19:13 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahnlP2lj_zl11I3b@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=jesseevg@gmail.com \
--cc=roykollensvendsen@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox