Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] package/libenca: fix C23 compatibility for getenv/getopt prototypes
Date: Fri, 29 May 2026 23:43:12 +0200	[thread overview]
Message-ID: <ahoILYWZG504uIQz@windsurf> (raw)
In-Reply-To: <20260418155515.9980-3-chakrabortyshubham66@gmail.com>

Hello,

On Sat, Apr 18, 2026 at 09:25:12PM +0530, Shubham Chakraborty wrote:
> GCC 15 defaults to C23, which removes support for K&R-style
> unprototyped function declarations. This causes build failures
> with strict modern C libraries.
> 
> Add proper function prototypes for getopt, getopt_long,
> getopt_long_only, getenv, and _getopt_internal to comply
> with C23 requirements.
> 
> Fixes build with musl libc and GCC 15.
> 
> Upstream: https://github.com/Project-OSS-Revival/enca/pull/97
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>

Thanks for this patch. Since it is a bugfix for an issue that exists
in the current version of libenca in Buildroot, this patch should have
been the first one in the series, before the version bump.

Also, this issue is visible in our autobuilders, so your commit log
should have carried a reference to the autobuilder issue being
fixed. I've added a reference to such a build failure, and applied
your patch to master. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-05-29 21:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18 15:55 [Buildroot] [PATCH 1/3] package/libenca: bump to version 1.22 and migrate to new upstream Shubham Chakraborty
2026-04-18 15:55 ` [Buildroot] [PATCH 2/3] DEVELOPERS: add Shubham Chakraborty for libenca Shubham Chakraborty
2026-05-29 21:53   ` Thomas Petazzoni via buildroot
2026-04-18 15:55 ` [Buildroot] [PATCH 3/3] package/libenca: fix C23 compatibility for getenv/getopt prototypes Shubham Chakraborty
2026-05-29 21:43   ` Thomas Petazzoni via buildroot [this message]
2026-04-18 18:54 ` [Buildroot] [PATCH 1/3] package/libenca: bump to version 1.22 and migrate to new upstream Marcus Hoffmann via buildroot
2026-05-29 21:53 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahoILYWZG504uIQz@windsurf \
    --to=buildroot@buildroot.org \
    --cc=chakrabortyshubham66@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox