From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org,
Giulio Benetti <giulio.benetti@benettiengineering.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/util-linux: fix LSMT_ROOT fallback definition
Date: Sat, 30 May 2026 12:02:14 +0200 [thread overview]
Message-ID: <ahq1EB1nE4rvp4An@windsurf> (raw)
In-Reply-To: <20260417060553.10171-1-chakrabortyshubham66@gmail.com>
Hello,
On Fri, Apr 17, 2026 at 11:35:53AM +0530, Shubham Chakraborty wrote:
> The fallback definition for LSMT_ROOT was incorrectly guarded
> with #ifdef instead of #ifndef, making it ineffective on systems
> with older kernel headers that don't define this constant.
>
> This caused build failures with "LSMT_ROOT undeclared" errors on
> autobuilders using older kernel headers.
This explanation wasn't really complete: my builds with old kernel
headers were building fine. A critical piece of information is that
the issue only happened with musl, because it added the SYS_statmount
definition between musl 1.2.5 and 1.2.6, so since musl 1.2.6,
util-linux believes statmount() is available, uses it, but if you have
old kernel headers that don't provide LSMT_ROOT, the build fails.
> diff --git a/package/util-linux/0001-include-mount-api-utils.h-fix-LSMT_ROOT-definition.patch b/package/util-linux/0001-include-mount-api-utils.h-fix-LSMT_ROOT-definition.patch
> new file mode 100644
> index 0000000000..3d0de62bfd
> --- /dev/null
> +++ b/package/util-linux/0001-include-mount-api-utils.h-fix-LSMT_ROOT-definition.patch
> @@ -0,0 +1,27 @@
> +From 72ff3b8998a675900fcb7c18c0e03f1552b13a8b Mon Sep 17 00:00:00 2001
> +From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> +Date: Tue, 14 Apr 2026 11:04:08 +0530
> +Subject: [PATCH] include/mount-api-utils.h: fix LSMT_ROOT definition
> +
> +Upstream: Pending
This is not useful in Buildroot. You have to provide an actual link
showing where it was submitted.
So I did submit the patch upstream:
https://lore.kernel.org/util-linux/20260530094932.2351791-1-thomas.petazzoni@bootlin.com/T/#u
with an improved commit message, included this improved patch in
Buildroot, and applied.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-05-30 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 6:05 [Buildroot] [PATCH v2 1/1] package/util-linux: fix LSMT_ROOT fallback definition Shubham Chakraborty
2026-05-30 10:02 ` Thomas Petazzoni via buildroot [this message]
2026-06-05 12:49 ` Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahq1EB1nE4rvp4An@windsurf \
--to=buildroot@buildroot.org \
--cc=chakrabortyshubham66@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox