Re: [Buildroot] [PATCH v2 1/1] package/python-libyang: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Vincent,

Thanks for submitting this patch, which I have applied to next after
doing some changes. See below.

On Thu, Apr 16, 2026 at 12:24:21PM +0200, Vincent Cruz wrote:

> diff --git a/package/python-libyang/Config.in b/package/python-libyang/Config.in
> new file mode 100644
> index 0000000000..c314beb0ea
> --- /dev/null
> +++ b/package/python-libyang/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_PYTHON_LIBYANG
> +	bool "python-libyang"
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libyang
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libyang
> +	depends on !BR2_STATIC_LIBS # libyang
> +	select BR2_PACKAGE_LIBYANG
> +	select BR2_PACKAGE_PYTHON_CFFI # runtime
> +	help
> +	  Python CFFI bindings for the libyang YANG library.
> +
> +	  This package provides the 'libyang' Python module, used by
> +	  higher-level tooling such as python-sysrepo.
> +
> +	  https://github.com/CESNET/libyang-python
> +
> +comment "python-libyang needs libyang"
> +	depends on !BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_STATIC_LIBS

This is not the correct way of providing dependency comments. We don't
care about the libyang dependency being commented on because you're
selecting libyang. We need comments about toolchain dependencies.

Changed to:

+comment "python-libyang needs a toolchain w/ threads, dynamic library"
+       depends on !BR2_TOOLCHAIN_HAS_SYNC_4
+       depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

> diff --git a/support/testing/tests/package/test_python_libyang.py b/support/testing/tests/package/test_python_libyang.py
> new file mode 100644
> index 0000000000..c485de2a67
> --- /dev/null
> +++ b/support/testing/tests/package/test_python_libyang.py
> @@ -0,0 +1,26 @@
> +import os
> +from xml.etree import ElementTree
> +from tests.package.test_python import TestPythonPackageBase
> +
> +
> +class TestPythonLibyang(TestPythonPackageBase):
> +    __test__ = True
> +    config = TestPythonPackageBase.config + \
> +        """
> +        BR2_PACKAGE_PYTHON3=y
> +        BR2_PACKAGE_PYTHON_LIBYANG=y
> +        """
> +    sample_scripts = ["tests/package/sample_python_libyang.py"]
> +
> +    def test_run(self):
> +        self.login()
> +        self.check_sample_scripts_exist()
> +
> +        cmd = self.interpreter + " " + os.path.basename(self.sample_scripts[0])
> +        output, exit_code = self.emulator.run(cmd, timeout=15)
> +        self.assertEqual(exit_code, 0)
> +
> +        tree = ElementTree.fromstringlist(output)
> +        self.assertEqual(tree.tag, '{urn:example}data')
> +        self.assertEqual(tree.find('.//{*}hostname').text, 'foobar')
> +        self.assertEqual(len(tree.find('.//{*}interface')), 2)

Rather than overriding test_run() to be able to run your custom logic
after running the same Python script, I've moved the XML validation
logic inside the sample Python script itself:

+xml = node.print_mem('xml', pretty=True)
+tree = ElementTree.fromstringlist(xml)
+assert tree.tag == '{urn:example}data'
+assert tree.find('.//{*}hostname').text == 'foobar'
+assert len(tree.find('.//{*}interface')) == 2

Committed to next with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot