From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/font-awesome: bump to version 7.2.0
Date: Sat, 30 May 2026 17:33:50 +0200 [thread overview]
Message-ID: <ahsDJ9eEdu3rwL0C@windsurf> (raw)
In-Reply-To: <20260404111250.154311-1-chakrabortyshubham66@gmail.com>
On Sat, Apr 04, 2026 at 04:42:49PM +0530, Shubham Chakraborty wrote:
> -FONT_AWESOME_VERSION = 4.7.0
> -FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,v$(FONT_AWESOME_VERSION))
> -FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
> -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
> +FONT_AWESOME_VERSION = 7.2.0
> +FONT_AWESOME_SITE = $(call github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))
> +FONT_AWESOME_LICENSE = OFL-1.1 (fonts), MIT (code), CC-BY-4.0 (icons)
Could you comment on the license changes?
> +FONT_AWESOME_LICENSE_FILES = LICENSE.txt
> +FONT_AWESOME_DIRECTORIES_LIST = css js scss webfonts sprites svgs
Why all those directories should be added? Are they relevant?
This needs more explanation in the commit message.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-05-30 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 11:12 [Buildroot] [PATCH] package/font-awesome: bump to version 7.2.0 Shubham Chakraborty
2026-05-30 15:33 ` Thomas Petazzoni via buildroot [this message]
2026-05-30 17:41 ` [Buildroot] [PATCH v2 0/2] " Shubham Chakraborty
2026-05-30 17:41 ` [Buildroot] [PATCH v2 1/2] " Shubham Chakraborty
2026-05-30 17:41 ` [Buildroot] [PATCH v2 2/2] DEVELOPERS: add Shubham Chakraborty for font-awesome Shubham Chakraborty
2026-05-30 17:46 ` [Buildroot] [PATCH v2 0/2] package/font-awesome: bump to version 7.2.0 Thomas Petazzoni via buildroot
-- strict thread matches above, loose matches on Subject: below --
2026-03-29 6:45 [Buildroot] [PATCH] " Shubham Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahsDJ9eEdu3rwL0C@windsurf \
--to=buildroot@buildroot.org \
--cc=chakrabortyshubham66@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox