Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 1/1] package/gettext-gnu: bump version to 1.0
Date: Sat, 30 May 2026 18:07:15 +0200	[thread overview]
Message-ID: <ahsK2eJNNKDZBkrZ@windsurf> (raw)
In-Reply-To: <20260421185136.2577202-1-bernd@kuhls.net>

Hello Bernd,

On Tue, Apr 21, 2026 at 08:51:36PM +0200, Bernd Kuhls wrote:

> Since upstream version 0.25 installed m4 files were moved from
> /usr/share/aclocal/ to /usr/share/gettext/m4/:
> https://lists.gnu.org/archive/html/bug-gettext/2025-05/msg00041.html
> https://bugzilla.redhat.com/show_bug.cgi?id=2366708#c10
> Added corresponding _AUTORECONF_OPTS to dovecot, libfuse & linknx.

Aside from those 3 packages, how much did you checked whether other
packages might now need this explicit path to /usr/share/gettext/m4 ?

> diff --git a/package/linknx/linknx.mk b/package/linknx/linknx.mk
> index d67f010093..8402429d8a 100644
> --- a/package/linknx/linknx.mk
> +++ b/package/linknx/linknx.mk
> @@ -9,6 +9,9 @@ LINKNX_SITE = $(call github,linknx,linknx,$(LINKNX_VERSION))
>  LINKNX_LICENSE = GPL-2.0+
>  LINKNX_LICENSE_FILES = LICENSE
>  LINKNX_INSTALL_STAGING = YES
> +LINKNX_AUTORECONF = YES
> +LINKNX_AUTORECONF_OPTS = --include=$(HOST_DIR)/share/gettext/m4

This change is weird. What are you adding AUTORECONF = YES? If this
package does not need to autoreconf, I suppose it doesn't need the
custom autoreconf opts?

Thanks for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-05-30 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 18:51 [Buildroot] [PATCH v4 1/1] package/gettext-gnu: bump version to 1.0 Bernd Kuhls
2026-05-30 16:07 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahsK2eJNNKDZBkrZ@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox