From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Jesse Van Gavere <jesseevg@gmail.com>,
Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/5] package/stellarium: fix qt5serialport dependency
Date: Sat, 30 May 2026 22:33:02 +0200 [thread overview]
Message-ID: <ahtJNrS18lS6lbyh@windsurf> (raw)
In-Reply-To: <20260530155718.657095-1-bernd@kuhls.net>
On Sat, May 30, 2026 at 05:57:14PM +0200, Bernd Kuhls wrote:
> qt5serialport is only needed when GPS support is enabled:
> https://github.com/Stellarium/stellarium/blob/v25.4/CMakeLists.txt#L623
>
> Please note that we disable telescope support by default so only gpsd
> enables the usage of qt5serialport.
>
> A backport to the LTS branches should be considered, adding
> qt5serialport as dependency without gpsd support causes the unneeded
> build of qt5serialport for stellarium. This situation exists for years
> and is not caused by recent upstream changes.
This is not correct. qt5serialport would only be pulled as a
dependency of stellarium if BR2_PACKAGE_QT5SERIALPORT=y. So in *any*
case qt5serialport would be part of the build. The only difference is
that it is a build dependency of stellarium for no reason. This is not
that much of a problem and probably doesn't deserve being backported,
so I dropped this paragraph, and applied your patch to master.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-05-30 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 15:57 [Buildroot] [PATCH v2 1/5] package/stellarium: fix qt5serialport dependency Bernd Kuhls
2026-05-30 15:57 ` [Buildroot] [PATCH v2 2/5] package/stellarium: add extra downloads Bernd Kuhls
2026-05-30 20:36 ` Thomas Petazzoni via buildroot
2026-06-05 12:49 ` Thomas Perale via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 3/5] package/stellarium: bump version to 26.1 Bernd Kuhls
2026-05-30 20:46 ` Thomas Petazzoni via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 4/5] package/qt6/qt6positioning: new package Bernd Kuhls
2026-05-30 21:15 ` Thomas Petazzoni via buildroot
2026-05-30 15:57 ` [Buildroot] [PATCH v2 5/5] package/stellarium: allow build with qt6 Bernd Kuhls
2026-05-30 21:20 ` Thomas Petazzoni via buildroot
2026-05-30 20:33 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahtJNrS18lS6lbyh@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=jesseevg@gmail.com \
--cc=roykollensvendsen@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox