Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Daniel Houck <Software@drhouck.me>
Cc: buildroot@buildroot.org, Chris Packham <judge.packham@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/micropython: bump to version 1.28.0
Date: Sat, 30 May 2026 23:27:20 +0200	[thread overview]
Message-ID: <ahtVrc-CD9fLtDgO@windsurf> (raw)
In-Reply-To: <20260508235516.3028284-1-Software@DRHouck.me>

Hello Daniel,

Thanks for patch, and the very good commit log. Nevertheless, I have a
few questions, see below.

On Fri, May 08, 2026 at 07:52:36PM -0400, Daniel Houck wrote:

> +if BR2_PACKAGE_MICROPYTHON_LIB
> +
> +config BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI
> +	bool "micropython-lib unix-ffi modules"
> +	default y
> +	select BR2_PACKAGE_LIBFFI
> +	select BR2_PACKAGE_PCRE2 # runtime

So libffi is only needed as a dependency when
BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI=y?

>  # When building from a tarball we don't have some of the dependencies that are in
>  # the git repository as submodules
>  MICROPYTHON_MAKE_OPTS += \
> @@ -71,7 +64,8 @@ ifeq ($(BR2_PACKAGE_MICROPYTHON_LIB),y)
>  define MICROPYTHON_COLLECT_LIBS
>  	$(EXTRA_ENV) PYTHONPATH=$(@D)/tools \
>  		package/micropython/collect_micropython_lib.py \
> -		$(@D) $(@D)/.built_pylib
> +		$(@D) $(@D)/.built_pylib \
> +		$(if $(BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI),--ffi,--no-ffi)

If yes, then this change is not needed. Indeed:

ifeq ($(BR2_PACKAGE_LIBFFI),y)
MICROPYTHON_DEPENDENCIES += host-pkgconf libffi
MICROPYTHON_MAKE_OPTS += MICROPY_PY_FFI=1
else
MICROPYTHON_MAKE_OPTS += MICROPY_PY_FFI=0
endif

will continue to bring libffi as a dependency if BR2_PACKAGE_LIBFFI is
enabled.

> diff --git a/package/micropython/collect_micropython_lib.py b/package/micropython/collect_micropython_lib.py
> index 8dce78337a..5fb74787a9 100755
> --- a/package/micropython/collect_micropython_lib.py
> +++ b/package/micropython/collect_micropython_lib.py

Could you perhaps improve a tiny bit the commit message to explain the
changes being brought to this script?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-05-30 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 23:52 [Buildroot] [PATCH 1/1] package/micropython: bump to version 1.28.0 Daniel Houck
2026-05-30 21:27 ` Thomas Petazzoni via buildroot [this message]
2026-06-01  0:25   ` Daniel Houck
2026-06-01  7:23     ` Thomas Petazzoni via buildroot
2026-06-01  8:38 ` [Buildroot] [PATCH v2 " Daniel Houck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahtVrc-CD9fLtDgO@windsurf \
    --to=buildroot@buildroot.org \
    --cc=Software@drhouck.me \
    --cc=judge.packham@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox