Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
To: thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ncurses: bump to version 6.6-20260425
Date: Sun, 31 May 2026 11:09:52 +0530	[thread overview]
Message-ID: <ahvJqD6wLJE1d3xQ@fedora> (raw)
In-Reply-To: <20260502173505.GA12345@buildroot.org>

On Sat, May 31, 2026, Thomas Petazzoni wrote:
> Where did you get this text from? It is nowhere to be found in
> https://invisible-island.net/ncurses/NEWS.html.

The items are in the NEWS file, but I paraphrased poorly and grouped
them incorrectly:

- The poll()/errno fix is from 20260411:
  https://invisible-island.net/ncurses/NEWS.html#t20260411
- The _nc_write_object, _nc_trim_sgr0, and read_SGR fixes are from
  20260418 (credited to Anthropic):
  https://invisible-island.net/ncurses/NEWS.html#t20260418
- The _nc_mouse_parse fix and konsole-direct/mintty/linux-alt1049
  are from 20260404:
  https://invisible-island.net/ncurses/NEWS.html#t20260404

I also got the _nc_trim_sgr0 description wrong -- it was a
source-pointer correction, not a limit-check.

> Also, you're updating from 20251231 to 20260425, there have been
> multiple releases, so surely the changelog is longer than that.

Yes, there are 17 intermediate snapshots (20260103 through 20260425)
and the commit message only covered 2-3 of them. That was a mistake.

> If you're using AI to generate those patches and their commit logs,
> stop immediately. We don't have the time to review AI slop.

Understood. I will send a v2 with a proper commit message covering
all intermediate snapshots, written from the upstream NEWS file.

Regards,
Shubham
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

       reply	other threads:[~2026-05-31  5:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260502173505.GA12345@buildroot.org>
2026-05-31  5:39 ` Shubham Chakraborty [this message]
2026-05-02 17:38 [Buildroot] [PATCH] package/ncurses: bump to version 6.6-20260425 Shubham Chakraborty
2026-05-30 22:05 ` Thomas Petazzoni via buildroot
2026-05-31  6:52   ` Shubham Chakraborty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahvJqD6wLJE1d3xQ@fedora \
    --to=chakrabortyshubham66@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox