Re: [Buildroot] [PATCH 3/3] package/qoriq-rcw-c: new package

[Vincent Jardin via buildroot <buildroot@buildroot.org>]

Hi Philippe,

Thanks for leading a Buildroot package on this tool.

See below some few comments,

Le 01/07/26 14:19, Philippe Nunes via buildroot a écrit :
> qoriq-rcw-c is a C reimplementation of NXP's rcw.py CLI for the
> pbiformat=2 QorIQ family (LS1028, LS1088, LS2088, LX2160). Built on
> top of libqoriq-rcw, it compiles a .rcw source file (preprocessed
> in-process via libmcpp) to the binary RCW + PBI image consumed by
> the SoC bootrom.
> 
> Beyond the rcw.py reference, qoriq-rcw-c adds two recovery features:
> 
>   --dump        read the live RCW from /dev/mem on a running board
>                 (post-PLL-lock RCWSR state; no PBI commands)
>   --dump-flash  recover the PBL preamble + PBI commands from the
>                 bootrom slot(s) in NOR / SD / eMMC

Right, but it means that the tool has to be compiled and run on the target,
not the host only.

> +++ b/package/qoriq-rcw-c/Config.in.host
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_HOST_QORIQ_RCW_C
> +	bool "host qoriq-rcw-c (C implementation)"
> +	select BR2_PACKAGE_HOST_LIBQORIQ_RCW
> +	help
> +	  C CLI built on top of libqoriq-rcw -- a faster drop-in
> +	  replacement for NXP's rcw.py for the pbiformat=2 SoC family
> +	  (LS1028, LS1088, LS2088, LX2160).

The main benefit (aka faster) to that it avoid pulling/compiling
a full python framework for the host mode, so we get a quick build.

> +
> +	  Adds two capabilities beyond rcw.py:
> +	    --dump          read live RCW from /dev/mem on a running
> +	                    board (post-PLL-lock RCWSR state, no PBI)
> +	    --dump-flash    recover PBL + PBI from the bootrom slot(s)
> +	                    in NOR / SD / eMMC

No, those options are not for the host. Moreover, the Config.in does
not need to detail all the runtime options.

> +# The upstream project is named "qoriq-rcw"; the "-c" suffix in the
> +# Buildroot package name distinguishes it from the existing
> +# host-qoriq-rcw package (which wraps NXP's rcw.py reference).

No need to duplicaate many time the same information.

> +QORIQ_RCW_C_VERSION = 1.0.1
> +QORIQ_RCW_C_SITE = $(call github,vjardin,qoriq-rcw,v$(QORIQ_RCW_C_VERSION))
> +QORIQ_RCW_C_SOURCE = qoriq-rcw-$(QORIQ_RCW_C_VERSION).tar.gz
> +
> +QORIQ_RCW_C_LICENSE = BSD-3-Clause
> +QORIQ_RCW_C_LICENSE_FILES = LICENSE
> +
> +HOST_QORIQ_RCW_C_DEPENDENCIES = host-libqoriq-rcw
> +
> +# Skip the pandoc-rendered man page: pandoc is a heavy Haskell-
> +# runtime build-time tool typically absent from packagers' minimal
> +# images, and host packages don't install man pages anyway. The
> +# 'man' feature option landed upstream in v1.0.1.
> +HOST_QORIQ_RCW_C_CONF_OPTS = -Dman=disabled

A short comment such as:
> +# Skip the pandoc-rendered man page: pandoc requires a full Haskell

would be better.


Best regards,
  Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot