Re: [Buildroot] [PATCH] package/libxkbcommon: build libxkbregistry when libxml2 is available

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alsey Coleman Miller <alseycmiller@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libxkbcommon: build libxkbregistry when libxml2 is available
Date: Fri, 7 Aug 2026 14:33:53 +0200	[thread overview]
Message-ID: <anXQGyU9dHYRMR0I@windsurf> (raw)
In-Reply-To: <20260807002109.2479876-1-alseycmiller@gmail.com>

Hello Alsey,

On Thu, Aug 06, 2026 at 08:21:09PM -0400, Alsey Coleman Miller wrote:
> libxkbregistry is the keyboard layout catalogue half of the library. It
> parses the XML layout registry and so needs libxml2, which is presumably
> why it was disabled unconditionally rather than wired to a dependency.
> 
> wine needs it. Its configure.ac requires XKBREGISTRY_LIBS alongside
> wayland-client, wayland-scanner, xkbcommon and linux/input.h before it
> will build the Wayland driver, and wine.mk passes --with-wayland for any
> build with BR2_PACKAGE_WAYLAND - which turns that notice into a hard
> error:
> 
>   checking for wayland-client.h... yes
>   checking for wl_display_connect in -lwayland-client... yes
>   checking for wayland-scanner... .../host/bin/wayland-scanner
>   checking for xkb_context_new in -lxkbcommon... yes
>   checking for wayland-egl.h... yes
>   checking for wl_egl_window_create in -lwayland-egl... yes
>   configure: error: Wayland development files not found, the Wayland
>     driver won't be supported.
>   This is an error since --with-wayland was requested.
> 
> Every other term of that test passes; only XKBREGISTRY_LIBS is empty, so
> wine and wayland together could not be built on any architecture.
> 
> Gated on BR2_PACKAGE_LIBXML2 rather than turned on outright, because
> meson.build takes dependency('libxml-2.0') unconditionally once
> enable-xkbregistry is set, so a target without libxml2 would fail to
> configure.
> 
> Signed-off-by: Alsey Coleman Miller <alseycmiller@gmail.com>

The patch obviously looks good and relevant. However, I have two
comments:

- Shouldn't this be associated with a change in the wine package to
  select BR2_PACKAGE_LIBXML2 when wayland support is enabled?

- We would need your commit log to be extended to indicate since when
  this problem exists. Indeed, since your change is a fix, we will
  have to figure out whether we need to backport it to our LTS branch
  2025.02.x. And for that, we need to understand if 2025.02.x is
  affected by the problem or not.

Thanks a lot in advance for your feedback!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot