Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Manuel Diener <manuel.diener@oss.othermo.de>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/python-questionary: new package
Date: Wed, 26 Aug 2026 11:54:54 +0200	[thread overview]
Message-ID: <ao63j4Ubi6sj2PkF@windsurf> (raw)
In-Reply-To: <20260826091851.467182-1-manuel.diener@oss.othermo.de>

Hello Manuel,

On Wed, Aug 26, 2026 at 11:18:50AM +0200, Manuel Diener wrote:
> Signed-off-by: Manuel Diener <manuel.diener@oss.othermo.de>
> ---
>  DEVELOPERS                                         |  1 +
>  package/Config.in                                  |  1 +
>  package/python-questionary/Config.in               |  7 +++++++
>  package/python-questionary/python-questionary.hash |  5 +++++
>  package/python-questionary/python-questionary.mk   | 14 ++++++++++++++
>  5 files changed, 28 insertions(+)
>  create mode 100644 package/python-questionary/Config.in
>  create mode 100644 package/python-questionary/python-questionary.hash
>  create mode 100644 package/python-questionary/python-questionary.mk

Thanks a lot for your patch. For Python modules, where issues usually
pop up at runtime rather than build time, we usually like to have a
small test. Could you have a look at adding a test in
support/testing/?

You can look at the zillions of tests
support/testing/tests/package/test_python_*.py, it's really trivial to
add one more test for your new package.

(And don't forget to update the DEVELOPERS file to also include your
test case.)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-08-26  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26  9:18 [Buildroot] [PATCH] package/python-questionary: new package Manuel Diener
2026-08-26  9:54 ` Thomas Petazzoni via buildroot [this message]
2026-08-28  9:02 ` [Buildroot] [PATCH v2] " Manuel Diener
2026-08-28  9:07   ` [Buildroot] [PATCH v3] " Manuel Diener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao63j4Ubi6sj2PkF@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=manuel.diener@oss.othermo.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox