From: Charlie Jenkins <thecharlesjenkins@gmail.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ncurses: Enable stripping of progs
Date: Sat, 15 Aug 2026 21:46:07 -0700 [thread overview]
Message-ID: <aoFAj5Sx-c-ULa9Q@blinky> (raw)
In-Reply-To: <87o6f2wva3.fsf@tarshish>
On Sun, Aug 16, 2026 at 07:20:52AM +0300, Baruch Siach wrote:
> Hi Charlie,
>
> On Sat, Aug 15 2026, Charlie Jenkins wrote:
> > Commit 2ab611c40ff08bd4a7922456fed22af6953af3b1("ncurses: fix build
> > failure with ncurses 6.1") added --disable-stripping to the ncurses
> > build because ncurses started stripping by default but using the host
> > strip instead of the cross strip.
> >
> > Enable stripping and change the strip program to $(TARGET_CROSS)strip.
> > This shrinks the binary sizes of the programs generated by
> > BR2_PACKAGE_NCURSES_TARGET_PROGS on aarch64 by:
> >
> > clear: 18k -> 10k
> > infocmp: 76k -> 62k
> > tabs: 27k -> 18k
> > tic: 103k -> 87k
> > toe: 27k -> 18k
> > tput: 33k -> 22k
> > tset: 33k -> 22k
>
> The 'target-finalize' target defined in top level Makefile should strip
> all target binaries. Lookup STRIPCMD in top Makefile.
>
> Doesn't that work for ncurses binaries?
That's a silly oversight on my part, thank you! I was looking at this
Makefile and the outputs but didn't look at the final outputs generated
by this step, oops.
- Charlie
>
> baruch
>
> >
> > Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
> > ---
> > package/ncurses/ncurses.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
> > index 5e2077500a..e017bacf6e 100644
> > --- a/package/ncurses/ncurses.mk
> > +++ b/package/ncurses/ncurses.mk
> > @@ -31,7 +31,7 @@ NCURSES_CONF_OPTS = \
> > --enable-const \
> > --enable-overwrite \
> > --enable-pc-files \
> > - --disable-stripping \
> > + --with-strip-program=$(TARGET_CROSS)strip \
> > --with-pkg-config-libdir="/usr/lib/pkgconfig" \
> > $(if $(BR2_PACKAGE_NCURSES_TARGET_PROGS),,--without-progs) \
> > --without-manpages
> >
> > ---
> > base-commit: e389f1b44c54660c7bb5512207a561e684b41595
> > change-id: 20260815-ncurses_strip-615a30afa120
> >
> > Best regards,
>
> --
> ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-08-16 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 1:27 [Buildroot] [PATCH] package/ncurses: Enable stripping of progs Charlie Jenkins
2026-08-16 4:20 ` Baruch Siach via buildroot
2026-08-16 4:46 ` Charlie Jenkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoFAj5Sx-c-ULa9Q@blinky \
--to=thecharlesjenkins@gmail.com \
--cc=baruch@tkos.co.il \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox