Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/kodi: add upstream patch to fix build on s390, mark unavailable on m68k
Date: Fri, 21 Aug 2026 00:18:02 +0200	[thread overview]
Message-ID: <aod9DnrVNEch93zS@windsurf> (raw)
In-Reply-To: <20260623051725.4526-1-bernd@kuhls.net>

On Tue, Jun 23, 2026 at 07:17:25AM +0200, Bernd Kuhls wrote:
> Build errors were found by the Gitlab pipelines with these defconfigs:
> 
> - bootlin-m68k-68040-uclibc
>   CMake Error at cmake/scripts/linux/ArchSetup.cmake:50 (message):
>     Unknown CPU: m68k
> 
> - bootlin-s390x-z13-glibc
>   CMake Error at cmake/scripts/linux/ArchSetup.cmake:50 (message):
>     Unknown CPU: s390x
> 
> Backport an upstream commit from the upcoming Piers branch to fix the
> restriction in ArchSetup.cmake.
> 
> This caused a different build error on m68k later on:
> 
> /builds/bkuhls/buildroot/br-test-pkg/bootlin-m68k-68040-uclibc/build/kodi-21.3-Omega/xbmc/utils/MathUtils.h:142:5:
>  error: unknown register name ‘st’ in ‘asm’
>   142 |     __asm__ __volatile__ (
> 
> because m68k is not part of the list of archs to disable asm code:
> https://github.com/xbmc/xbmc/blob/Omega/xbmc/utils/MathUtils.h#L26
> 
> Upstream rejected to add m68k there:
> https://github.com/xbmc/xbmc/pull/22519
> https://github.com/xbmc/xbmc/pull/22357#issuecomment-1368358471
> 
> so we disable m68k in BR2_PACKAGE_KODI_ARCH_SUPPORTS.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Thanks, applied to master!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-08-20 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  5:17 [Buildroot] [PATCH 1/1] package/kodi: add upstream patch to fix build on s390, mark unavailable on m68k Bernd Kuhls
2026-08-20 22:18 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aod9DnrVNEch93zS@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox