Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Joseph Kogut <joseph@anodize.com>
Cc: joseph.kogut@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/passt: disable on uclibc
Date: Mon, 7 Sep 2026 08:08:24 +0200	[thread overview]
Message-ID: <ap5UEVoz1-Vb0P0h@windsurf> (raw)
In-Reply-To: <20260818-passt-20260728-v1-1-aa8bc1ce2c5a@anodize.com>

Hello,

On Tue, Aug 18, 2026 at 01:55:33PM -0700, Joseph Kogut wrote:
> Upstream lists uClibc-ng support as a "nice-to-have, eventually", and
> tracks the required build fixes as an enhancement:
> 
> https://bugs.passt.top/show_bug.cgi?id=5
> 
> passt relies on interfaces and definitions missing from uClibc,
> resulting in build failures such as:
> 
> qrap.c:145:25: error: 'ARG_MAX' undeclared
> tcp.c:2926:34: error: storage size of 'wnd' isn't known
> tcp.c:3321:47: error: 'TCP_SEND_QUEUE' undeclared
> 
> Disable passt for uClibc toolchains and propagate the dependency to
> Podman's passt backend.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7e4/7e4434e01baece4d090e44b4b3713f2eeefc1e27/
>  - http://autobuild.buildroot.org/results/3f6/3f60889b4599f1bc42a69076f6fe469517ea9ab5/
> 
> Signed-off-by: Joseph Kogut <joseph@anodize.com>

Thanks, I have applied.

However:

- ARG_MAX is not a standard definition, the code should be using
  getconf() to get this kind of value

- The code uses ARG_MAX incorrectly. ARG_MAX is the maximum number of
  bytes occupied by arguments, but the code uses it as the max number
  of arguments.

For the other two problems, I guess a bug should be reported to
uClibc. I've Cc'ed Waldemar, uClibc-ng's maintainer.

> diff --git a/package/passt/Config.in b/package/passt/Config.in
> index fca1dff7c5..d06cc3e482 100644
> --- a/package/passt/Config.in
> +++ b/package/passt/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PASST
>  	bool "passt"
> +	depends on !BR2_TOOLCHAIN_USES_UCLIBC

I added a comment above this to explain why.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-09-07  6:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 20:55 [Buildroot] [PATCH 0/2] package/passt: dependency fixes and version bump Joseph Kogut
2026-08-18 20:55 ` [Buildroot] [PATCH 1/2] package/passt: disable on uclibc Joseph Kogut
2026-09-07  6:08   ` Thomas Petazzoni via buildroot [this message]
2026-08-18 20:55 ` [Buildroot] [PATCH 2/2] package/passt: bump to version 2026_07_28.f8df3f1 Joseph Kogut
2026-09-06 21:15   ` Thomas Petazzoni via buildroot
2026-09-07  6:02     ` Thomas Petazzoni via buildroot
2026-09-07 20:23       ` Joseph Kogut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap5UEVoz1-Vb0P0h@windsurf \
    --to=buildroot@buildroot.org \
    --cc=joseph.kogut@gmail.com \
    --cc=joseph@anodize.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox