Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/libmpeg2: fix build with GCC 15
Date: Sun, 20 Sep 2026 12:12:16 +0200	[thread overview]
Message-ID: <aq-xI2hUSAjajzbx@windsurf> (raw)
In-Reply-To: <20260810165106.3930140-1-chakrabortyshubham66@gmail.com>

On Mon, Aug 10, 2026 at 10:21:05PM +0530, Shubham Chakraborty wrote:
> GCC 15 defaults to C23, which no longer supports K&R-style empty
> parameter list declarations used in libmpeg2. To avoid carrying intrusive
> patches that rewrite legacy K&R-style declarations, pass -std=gnu89
> to CFLAGS to restore the older compiler behavior.
> 
> Fixes: http://autobuild.buildroot.net/results/53d/53daf0b4bd8b476252ca219e53a966405ece7e51
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>

Thanks to the input from Bernd, I was able to reproduce the
issue. Except that the issue also occurred with GCC 14.x, which made
your commit log and comment in the code not quite accurate.

Turns out that GCC 15.x indeed defaults to C23, causing the problem.

But since the bump of autoconf to 2.73, when GCC 14.x is used,
autoconf injects -std=c23 in the CFLAGS... also causing the
problem. There are even autobuilder failures reported for this issue.

So I applied your patch, but after rewriting the commit log and
changing the comment in libmpeg2.mk.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-09-20 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21  8:14 [Buildroot] [PATCH] package/libmpeg2: fix build with GCC 15 Shubham Chakraborty
2026-05-31 12:10 ` Thomas Petazzoni via buildroot
2026-08-10 16:51 ` [Buildroot] [PATCH v2] " Shubham Chakraborty
2026-09-18 22:09   ` Thomas Petazzoni via buildroot
2026-09-20 10:12   ` Thomas Petazzoni via buildroot [this message]
2026-09-25 14:43   ` Raphaël Mélotte via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq-xI2hUSAjajzbx@windsurf \
    --to=buildroot@buildroot.org \
    --cc=chakrabortyshubham66@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox