Re: [Buildroot] [PATCH 2/3] package/brcmfmac_sdio-firmware: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for your feedback.

On Fri, Sep 18, 2026 at 01:08:35PM +0200, Jean-Paul Etienne wrote:
> Hi Thomas,
> Before adding this package, I've checked linux-firmware and saw that it does
> not support brcmfmac43456-sdio.bin firmware
> required for the AP6256 chip.
> However, while looking in the brcmfmac_sdio-firmware-rpi package on buildroot I
> see it supports the firmware:
> 
> ddf83f2100885b166be52d21c8966db164fdd4e1d816aca2acc67ee9cc28d726
>  brcmfmac43456-sdio.bin
> 44e0bb322dc1f39a4b0a89f30ffdd28bc93f7d7aaf534d06d229fe56f6198194
>  brcmfmac43456-sdio.txt
> 2dbd7d22fc9af0eb560ceab45b19646d211bc7b34a1dd00c6bfac5dd6ba25e8a
>  brcmfmac43456-sdio.clm_blob (default_config)
> 
> But brcmfmac_sdio-firmware package has specific firmware and config for the
> rockpi4b board as follows:
> 78085a816d23d9877e3ab872d8eb142646bfde18afd2c7a5b89885327a287d19
>  brcmfmac43456-sdio.radxa,rockpi4b.bin
> 343d1c79cfe0e10e1777e3de19a0302f748f69fa8356cab2c36ca0cf90bbcf0e
>  brcmfmac43456-sdio.radxa,rockpi4b.txt
> 
> And they are not just symlinks to the default brcmfmac43456-sdio.bin
> or brcmfmac43456-sdio.txt
> So I thought this package could be useful to the community especially since it
> supports a lot of boards.
> 
> I'll update the patch.

In what direction will you update the patch? I guess the main issue is
that your package was named just brcmfmac_sdio-firmware, while in fact
it is specific to the rockpi4b board.

But instead of doing this, why don't you send a patch to
linux-firmware to add what's missing?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot