Re: [Buildroot] [PATCH] package/tftpd: bump to version 5.4

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for the patch.

On Thu, Aug 20, 2026 at 03:35:00PM +0300, Nathan Bloch wrote:
> Switch from a post-5.3 git snapshot back to the release tarball, now
> that 5.4 is out.
> 
> This also fixes a regression in the snapshot we pin: the autoconf
> modernization in fefaa2cc5c2a renamed the msg_control define to
> HAVE_STRUCT_MSGHDR_MSG_CONTROL, but tftpd/recvfrom.c kept testing for
> HAVE_MSGHDR_MSG_CONTROL, so the recvmsg() code path is compiled out and
> the fallback is used instead. That fallback reads the address family
> from the 'from' address before recvfrom() has filled it in, so the
> first request after each start creates the transfer socket with
> AF_UNSPEC, gets EAFNOSUPPORT and exits without answering or logging the
> request. Fixed upstream in 5.4 by e701714f7a8c ("autoconf: correct the
> new #define names after modernization") and 82223bbf9391 ("tftpd/
> recvfrom.c: don't derive local address family before recvfrom()").
> 
> Drop TFTPD_AUTORECONF and its m4 include directory: the release tarball
> ships a configure script.
> 
> Update the license information: 5.4 replaced the per-file license
> preambles with SPDX tags and a LICENSES/ directory, so tftpd/tftpd.c no
> longer contains any license text. Both binaries are built from a mix of
> BSD-4-Clause-UC and BSD-3-Clause files.
> 
> Add a patch for the only build failure in 5.4: tftpd/path.h uses bool
> without including <stdbool.h>, which requires a C23 compiler.
> 
> Fixes: d4a84e61615553ff678d3c3b52ed33f898e9fcc9

When you say it fixes this commit, is it because of the regression
you're mentioning in the commit log?

Minor: when providing a fixes tag referring to a commit, also put the
commit title:

Fixes: <hash> ("<title>")

because here I was wondering whether
d4a84e61615553ff678d3c3b52ed33f898e9fcc9 was a Buildroot commit
reference or an autobuilder failure reference.

> diff --git a/package/tftpd/0001-tftpd-path.h-add-missing-stdbool.h-include.patch b/package/tftpd/0001-tftpd-path.h-add-missing-stdbool.h-include.patch
> new file mode 100644
> index 0000000000..5995ecd937
> --- /dev/null
> +++ b/package/tftpd/0001-tftpd-path.h-add-missing-stdbool.h-include.patch
> @@ -0,0 +1,39 @@
> +From: Nathan Bloch <nblochn@gmail.com>
> +Date: Wed, 20 Aug 2026 12:00:00 +0300
> +Subject: [PATCH] tftpd/path.h: add missing <stdbool.h> include
> +
> +path.h declares parse_path() with a bool parameter, and both of its
> +users, path.c and tftpd.c, use bool without including <stdbool.h>
> +themselves. That only compiles where bool is a keyword, i.e. C23, so
> +the build fails with any compiler defaulting to C17 or older:
> +
> +  path.h:7:43: error: unknown type name 'bool'
> +  path.c:55:33: error: 'true' undeclared (first use in this function)
> +  tftpd.c:391:5: error: unknown type name 'bool'
> +
> +gcc defaults to gnu17 up to and including 14.x, so 5.4 does not build
> +with any of them.
> +
> +Include <stdbool.h> from path.h, the header declaring the bool-taking
> +prototype, which both users already include.
> +
> +Upstream: not submitted yet, upstream master is affected as well.

Patches should be submitted upstream first. Turns out that I guess
this issue was fixed upstream by commit
8694c57ac439db5e776ecac6ca92333dd0bf3285, which took a different
approach than your patch.

Also, not your fault but since your patch, upstream has released 6.0
and 6.1 (but that's not why I didn't apply your patch, it's really
because the patch had not been submitted upstream).

Could you spin a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot