Re: [Buildroot] [PATCH v2 1/2] package: openscap: fix build failure when crypto backend is not gcrypt

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/2] package: openscap: fix build failure when crypto backend is not gcrypt
Date: Fri, 18 Sep 2026 23:50:30 +0200	[thread overview]
Message-ID: <aq2x6HGQM74iI6Fr@windsurf> (raw)
In-Reply-To: <20260907-fix_openscap-v2-1-28f8f6ee3248@bootlin.com>

Hello Alexis,

On Mon, Sep 07, 2026 at 03:47:36PM +0200, Alexis Lothoré via buildroot wrote:
> When enabling the openscap package and the libnss library _but not_
> libgcrypt, the build can fail on the following error:
> 
>   ../src/libopenscap.so.33.1.3: undefined reference to `crapi_init'
> 
> The issue is due to the fact that the corresponding Makefile
> systematically forces -DWITH_CRYPTO=gcrypt: openscap CMake
> instrumentation then searches only this backend, fails to find it,
> assumes that no crypto backend is available, and so does not include the
> crapi_object in the final link step.
> 
> Commit 7c85f3adf4a8 ("package/openscap: new package") took into account
> the fact that openscap isn't currently able to build if no crypto backend
> is provided (see [0]), and so made sure to force libgcrypt inclusion if
> libnss is not included. Since then, two fixes ([1] and [2]) have been
> integrated upstream to allow building openscap with any backend.
> 
> Do not systematically enforce libgcrypt anymore through WITH_CRYPTO:
> rather than testing nss presence, and falling back to libgcrypt, allow
> both to be absent, and so relax the libgcrypt dependency to make it
> optional as well. Bring the two upstream patches allowing openscap build
> without any crypto backend.  Those patches can be dropped once openscap
> v1.4.5 is released.
> 
> [0] https://github.com/OpenSCAP/openscap/issues/2310
> [1] https://github.com/OpenSCAP/openscap/commit/d12d820a9493b0a0ee1ad4b0aeaa87da28aa0080
> [2] https://github.com/OpenSCAP/openscap/commit/5b858d1786c025cbd50dfc284b252c3ee6dd99dc
> 
> Fixes: https://autobuild.buildroot.org/results/4c905c1b0ee384149c3d85e8f2ebf0af3a12c2ad/
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Thanks, applied!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot