Re: [Buildroot] [PATCH 2/4] support/scripts/check-host-bins: report RPATH errors after library errors

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, Sep 09, 2026 at 07:39:23AM -0500, Matthew Weber wrote:
> The missing-library check sets the overall error status before the RPATH
> check. Use a separate flag for the RPATH diagnostic header so both errors are
> reported when applicable.

The commit log is honestly hard to grasp.

> diff --git a/support/scripts/check-host-bins b/support/scripts/check-host-bins
> index cddf6a08b2..5233f6cd1d 100755
> --- a/support/scripts/check-host-bins
> +++ b/support/scripts/check-host-bins
> @@ -12,12 +12,13 @@ main() {
>      local pkg="${1}"
>      local hostdir="${2}"
>      local perpackagedir="${3}"
> -    local file ret
> +    local file ret rpath_hdr missing_libs

missing_libs is added as a variable, but not used anywhere in this
patch. Unrelated change?

Overall this change should really be a review comment to my patch
"support/scripts/check-host-bins: add new check on host binaries/libs"
as it's a bug/issue introduced by this not yet merged patch.

But isn't your patch going to offer a messed up output like this:

****
**** ERROR: package %s uses libs not in HOST_DIR:
**** ERROR: package %s installs executables without proper RPATH:
****   file1
****   file2

isn't that a bit odd?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot