From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/tpm2-openssl: bump version to 1.3.0
Date: Wed, 16 Sep 2026 21:26:17 +0200 [thread overview]
Message-ID: <aqrtL9ZFmaHmfT6f@windsurf> (raw)
In-Reply-To: <20260911221033.880486-1-bernd@kuhls.net>
On Sat, Sep 12, 2026 at 12:10:33AM +0200, Bernd Kuhls wrote:
> https://github.com/tpm2-software/tpm2-openssl/releases/tag/1.3.0
>
> Updated license hash due to copyright year bump:
> https://github.com/tpm2-software/tpm2-openssl/commit/3fb3a5ff7fcd9921ad6e933aed8f34e8e63d46db
>
> Removed -Werror -Wall from Makefile.{am, in} which was added by upstream
> commit https://github.com/tpm2-software/tpm2-openssl/commit/c3a8758cad1520d36d6cb87aa87ff8012f3283d8
> first included in this release.
>
> This fixes a build error seen with the Gitlab pipelines for
> bootlin-aarch64-glibc-old:
>
> src/tpm2-provider-encoder.c:
> In function ‘tpm2_rsa_encoder_encode_SubjectPublicKeyInfo_der’:
> src/tpm2-provider-encoder.c:86:71: error: the comparison will always
> evaluate as ‘true’ for the address of ‘tpm2_rsa_encode_public_
> SubjectPublicKeyInfo_der’ will never be NULL [-Werror=address]
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Applied to master, after changing one aspect, see below.
> -TPM2_OPENSSL_VERSION = 1.2.0
> +TPM2_OPENSSL_VERSION = 1.3.0
> TPM2_OPENSSL_SITE = https://github.com/tpm2-software/tpm2-openssl/releases/download/$(TPM2_OPENSSL_VERSION)
> TPM2_OPENSSL_LICENSE = BSD-3-Clause
> TPM2_OPENSSL_LICENSE_FILES = LICENSE
> TPM2_OPENSSL_INSTALL_STAGING = YES
> TPM2_OPENSSL_DEPENDENCIES = host-pkgconf openssl tpm2-tss
>
> +define TPM2_OPENSSL_DISABLE_WERROR
> + $(SED) 's/-Werror -Wall //g' -i $(@D)/Makefile.*
> +endef
> +TPM2_OPENSSL_PRE_CONFIGURE_HOOKS += TPM2_OPENSSL_DISABLE_WERROR
I really don't like this kind of random patching, so I've replaced
this with:
+# Need to disable -Werror to avoid warnings being treated as errors
+# with some gcc versions
+TPM2_OPENSSL_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-error"
which is a lot cleaner IMO.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-09-16 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 22:10 [Buildroot] [PATCH 1/1] package/tpm2-openssl: bump version to 1.3.0 Bernd Kuhls
2026-09-16 19:26 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqrtL9ZFmaHmfT6f@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox