Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: buildroot@buildroot.org, James Hilliard <james.hilliard1@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/python-grpcio: disable for the MIPS n32 ABI
Date: Wed, 16 Sep 2026 21:46:39 +0200	[thread overview]
Message-ID: <aqrxwsTrc8fd_jDI@windsurf> (raw)
In-Reply-To: <20260908093538.2715153-1-yegorslists@gmail.com>

Hello,

Thanks a lot for this patch. Number of questions below.

On Tue, Sep 08, 2026 at 11:35:38AM +0200, Yegor Yefremov via buildroot wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> The bundled abseil-cpp only implements DirectMmap() with mmap2 for the
> o32 ABI on MIPS:
> 
>     #if ... (defined(__mips__) && _MIPS_SIM == _MIPS_SIM_ABI32) || ...
> 
> With the n32 ABI, the "remaining 64-bit architectures" fallback is
> selected instead, which fails to build because long is 32-bit there:
> 
>     third_party/abseil-cpp/absl/base/internal/direct_mmap.h:130:39:
>         error: static assertion failed: Platform is not 64-bit
>       130 |   static_assert(sizeof(unsigned long) == 8, "Platform is not 64-bit");
>           |                 ~~~~~~~~~~~~~~~~~~~~~~^~~~
>     third_party/abseil-cpp/absl/base/internal/direct_mmap.h:130:39:
>         note: the comparison reduces to '(4 == 8)'

So assume this is fixing:

  https://autobuild.buildroot.net/results/90405c0a3d0b2e929d5074305906e6fe3679298c/

 ?

If so, can you add a Fixes: tag?

Also, can you investigate since when this problem exists, so that our
LTS maintainers can understand whether they need to backport this fix
or not?

> Upstream abseil has no support for the n32 ABI, so disable the package
> for that ABI. The o32 and n64 ABIs are unaffected.

But then doesn't package/abseil-cpp/Config.in also need to be
modified?

And is it possible for python-grpcio to use the Buildroot-provided
abseil, instead of using its bundled version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-09-16 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  9:35 [Buildroot] [PATCH] package/python-grpcio: disable for the MIPS n32 ABI Yegor Yefremov via buildroot
2026-09-16 19:46 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqrxwsTrc8fd_jDI@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox