Re: [Buildroot] [PATCH 1/1] package/nnn: bump to version 5.3

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks for your patch! A number of questions/comments below.

On Mon, Sep 07, 2026 at 09:45:37PM +0200, Alexander Shirokov wrote:
> This commit updates the package version to 5.3.
> 
> Changelog: https://github.com/jarun/nnn/blob/v5.3/CHANGELOG
> 
> It also brings some improvements.
> 
> 1. Adds libatomic dependency, as the library is required since commit
> 7ce4913bc39bc3b34a0e2c3de7153fb09d489152.

Is this upstream commit part of this version bump 5.1 -> 5.3, or did
it already exist?

> 
> 2. Adds a dependency on BR2_TOOLCHAIN_HAS_THREADS to prevent failures
> in test-pkg.

Is this new dependency needed because of the version bump, or was it
already needed with version 5.1?

If some of those topics are independent from the version bump, they
should be in a separate commit.


> config BR2_PACKAGE_NNN
> 	bool "nnn"
> 	depends on BR2_USE_MMU # fork
>+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
>+	depends on BR2_TOOLCHAIN_HAS_THREADS

This needs an update of the Config.in comment:

comment "nnn needs a toolchain with wchar"
        depends on BR2_USE_MMU # fork
        depends on !BR2_USE_WCHAR

should become:

comment "nnn needs a toolchain with wchar, threads"
        depends on BR2_USE_MMU # fork
	depends on BR2_TOOLCHAIN_HAS_ATOMIC
        depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

>  ################################################################################
>  
> -NNN_VERSION = 5.1
> +NNN_VERSION = 5.3
>  NNN_LICENSE = BSD-2-Clause
>  NNN_LICENSE_FILES = LICENSE
>  NNN_SITE = $(call github,jarun,nnn,v$(NNN_VERSION))
> @@ -15,10 +15,12 @@ NNN_MAKE_FLAGS = \
>  	CFLAGS_OPTIMIZATION= \
>  	PREFIX=/usr
>  
> +# Must be passed in env so it can be appended to by the Makefile
> +NNN_MAKE_ENV += LDLIBS="-latomic"

Should be conditional on BR2_TOOLCHAIN_HAS_LIBATOMIC.

>  ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
>  NNN_DEPENDENCIES += musl-fts
> -# Must be passed in env so it can be appended to by the Makefile
> -NNN_MAKE_ENV += LDLIBS="-lfts"
> +NNN_MAKE_ENV += LDLIBS="-lfts -latomic"

We want to avoid duplicating this.

>  endif

So probably:

ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
NNN_LDLIBS = -latomic
endif

ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
NNN_DEPENDENCIES += musl-fts
NNN_LDLIBS += -lfts
endif

NNN_MAKE_ENV += LDLIBS="$(NNN_LDLIBS)"

Could you have a look at sending a new version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot