From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: John Ernberg <j@j-ernberg.se>
Cc: buildroot@buildroot.org,
Raphael Pavlidis <raphael.pavlidis@gmail.com>,
Adam Ford <aford173@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/x11r7/xwayland: glx depend on mesa3d{, -headers}
Date: Mon, 28 Sep 2026 10:51:19 +0200 [thread overview]
Message-ID: <aroqYveaULyifpvQ@windsurf> (raw)
In-Reply-To: <20260927204842.1113860-3-j@j-ernberg.se>
Hello,
On Sun, Sep 27, 2026 at 10:48:42PM +0200, John Ernberg wrote:
> The glx feature of xwayland checks for dri.pc, which is only provided
> by mesa3d{,-headers}.
>
> Establish the dependency chain properly, otherwise xorg-server cannot be
> built when using per-package directories, and will fail to build randomly
> in the default build when a provider of LIBGL has been enabled.
>
> Graphics stacks will use either mesa3d or mesa3d-headers (nvidia), since
> those packages are in conflict with eachother adding them both as
> conditional deps is fine, we can't accidentally depend on both.
>
> Cc: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> Reported-by: Adam Ford <aford173@gmail.com>
> Link: https://lore.kernel.org/buildroot/20260803140815.617446-1-aford173@gmail.com/
> Signed-off-by: John Ernberg <j@j-ernberg.se>
> ---
>
> Adam, since this is basically your solution and I just cleaned it up,
> let me know if you want a Co-developed-by tag or something to that extent.
>
> package/x11r7/xwayland/xwayland.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/x11r7/xwayland/xwayland.mk b/package/x11r7/xwayland/xwayland.mk
> index 02a21b96c1..e6ac104e0a 100644
> --- a/package/x11r7/xwayland/xwayland.mk
> +++ b/package/x11r7/xwayland/xwayland.mk
> @@ -39,7 +39,10 @@ endif
>
> ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
> XWAYLAND_CONF_OPTS += -Dglx=true
> -XWAYLAND_DEPENDENCIES += libgl
> +XWAYLAND_DEPENDENCIES += \
> + libgl \
> + $(if $(BR2_PACKAGE_MESA3D),mesa3d) \
> + $(if $(BR2_PACKAGE_MESA3D_HEADERS),mesa3d-headers)
For the same reason as for PATCH 1/2, this cannot be correct, as you
have no guarantee that mesa3d is your OpenGL provider.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-09-28 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 20:48 [Buildroot] [PATCH 0/2] xorg mesa3d dependency fixes John Ernberg
2026-09-27 20:48 ` [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: glx depend on mesa3d{, -headers} John Ernberg
2026-09-28 8:50 ` Thomas Petazzoni via buildroot
2026-09-28 21:01 ` John Ernberg
2026-09-27 20:48 ` [Buildroot] [PATCH 2/2] package/x11r7/xwayland: " John Ernberg
2026-09-28 8:51 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroqYveaULyifpvQ@windsurf \
--to=buildroot@buildroot.org \
--cc=aford173@gmail.com \
--cc=j@j-ernberg.se \
--cc=raphael.pavlidis@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox