Re: [Buildroot] [PATCH] package/nettest: not available for the i586 Rust targets

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks a lot for your patch!

On Sun, Oct 11, 2026 at 09:57:35PM +0300, Bogdan Radulescu wrote:
> nettest depends, through rustls, quinn and rcgen, on the ring crate,
> which refuses to build for 32-bit x86 targets without SSE and SSE2:
> 
>   error[E0080]: evaluation panicked: assertion failed: cfg!(target_feature = "sse") && cfg!(target_feature = "sse2")
>     --> .../VENDOR/ring/src/cpu/intel.rs:26:9
> 
> Buildroot uses the i586-unknown-linux-{gnu,musl} Rust targets when
> BR2_ARCH is "i586" (i586, pentium-mmx, geode, c3, winchip...), and
> those targets do not enable SSE/SSE2. The i686 Rust targets enable
> SSE2 by default, so ring builds fine there.
> 
> Make nettest unavailable when the Rust target architecture is i586.
> 
> Fixes: https://autobuild.buildroot.org/results/d04f770538412bee77851142ee007f2ff107e0ec

Could you trace back which Buildroot introduced the issue in the first
place?

Adding a tag:

Fixes: <commit hash> ("<commit title>")

would be ideal. If the problem exists since the package was
introduced, then you can simply to the commit introducing the package
as the commit being fixed.

> +	# ring needs SSE/SSE2, which the i586 Rust targets lack
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH != "i586"

I believe you should rather have a dependency on SSE2, like
https://patchwork.buildroot.org/project/buildroot/patch/20260617161331.141666-1-shirokovalexs@gmail.com/
does.

Indeed, there are some i686 platforms that do not have SSE2, and they
would continue to fail building even with your patch.

Could you work on a v2 to address those two comments?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot