From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nevo Hed <nhed+buildroot@starry.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
arnout@rnout.be, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/umtprd: expose package build options
Date: Tue, 13 Oct 2026 10:34:06 +0200 [thread overview]
Message-ID: <as3sjbzkJ8Teyy8t@windsurf> (raw)
In-Reply-To: <0100019e947c6908-6c76a09a-23cf-406f-82ce-3889dd5dd255-000000@email.amazonses.com>
Hello Nevo,
Thanks a lot for your patch, and sorry for the delay! See below some
review.
On Thu, Jun 04, 2026 at 09:14:01PM +0000, Nevo Hed via buildroot wrote:
> Primary impetus: BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY:
> By default umtprd does not communicate daemon readyness. Version
> 1.6.8 added a build option that enables creating a Type=notify
> systemd service.
>
> Added two other relevant build options that were available in the
> Makefile:
> - BR2_PACKAGE_UMTPRD_DEBUG
> - BR2_PACKAGE_UMTPRD_SYSLOG
>
> Signed-off-by: Nevo Hed <nhed+buildroot@starry.com>
> ---
> package/umtprd/Config.in | 19 ++++++++++++++++++-
> package/umtprd/umtprd.mk | 14 +++++++++++++-
> 2 files changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/package/umtprd/Config.in b/package/umtprd/Config.in
> index 24bf119549..dff5a44583 100644
> --- a/package/umtprd/Config.in
> +++ b/package/umtprd/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_UMTPRD
> +menuconfig BR2_PACKAGE_UMTPRD
> bool "umtprd"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
> @@ -7,5 +7,22 @@ config BR2_PACKAGE_UMTPRD
>
> https://github.com/viveris/uMTP-Responder
>
> +if BR2_PACKAGE_UMTPRD
> +
> +if BR2_PACKAGE_SYSTEMD
> +
> +config BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY
> + bool "Tell Systemd when uMTP-Responder is ready "
There is no need to have a separate option for this, just enable
systemd notify support at soon as BR2_PACKAGE_SYSTEMD=y.
> +endif
> +
> +config BR2_PACKAGE_UMTPRD_DEBUG
> + bool "Enable debug"
What does it do? Perhaps we want to use BR2_ENABLE_RUNTIME_DEBUG=y
instead of having a custom option?
> +config BR2_PACKAGE_UMTPRD_SYSLOG
> + bool "Send output to syslog"
Where is the output going otherwise? Shouldn't sending the output to
syslog simply be the unconditional default?
Peter, Arnout, any opinion on this?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-10-13 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 21:14 [Buildroot] [PATCH] package/umtprd: expose package build options Nevo Hed via buildroot
2026-10-13 8:34 ` Thomas Petazzoni via buildroot [this message]
2026-10-13 11:12 ` Peter Korsgaard
2026-10-13 13:04 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as3sjbzkJ8Teyy8t@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@rnout.be \
--cc=nhed+buildroot@starry.com \
--cc=paul@crapouillou.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox