Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	James Hilliard <james.hilliard1@gmail.com>,
	 Guillaume William Brs <guillaume.bressaix@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/python-scipy: remove license file
Date: Sat, 3 Oct 2026 18:15:47 +0200	[thread overview]
Message-ID: <asEp-UvwtZnTyfY9@windsurf> (raw)
In-Reply-To: <20261003160713.1350799-1-bernd@kuhls.net>

On Sat, Oct 03, 2026 at 06:07:12PM +0200, Bernd Kuhls wrote:
> Buildroot commit 5d695881f8dc68ff1efe2cce75dda462c5990e3c bumped the
> package from 1.16.3 to 1.17.1. In Version 1.17.0 upstream removed the
> license file scipy/sparse/linalg/_eigen/arpack/ARPACK/COPYING:
> https://github.com/scipy/scipy/commit/14dffda0b83c46728a7c88998804a4663bb735b3
> 
> causing an error with make target python-scipy-legal-info:
> 
> ERROR: while checking hashes from package/python-scipy/python-scipy.hash
> ERROR: scipy/sparse/linalg/_eigen/arpack/ARPACK/COPYING has wrong sha256 hash:
> ERROR: expected: 0926566f9f406178d1214f8cc796e166b1213dd7c05e0c5b461a8b8ac9e50bbe
> ERROR: got     :
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/python-scipy/python-scipy.hash | 1 -
>  package/python-scipy/python-scipy.mk   | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/package/python-scipy/python-scipy.hash b/package/python-scipy/python-scipy.hash
> index 27a72904d2..5be848c8ad 100644
> --- a/package/python-scipy/python-scipy.hash
> +++ b/package/python-scipy/python-scipy.hash
> @@ -6,5 +6,4 @@ sha256  221e59f5e910fd7f94e44f0dac77436a11338c285c6346232e4a850a50da0e94  LICENS
>  sha256  606209a000716c5f66e33e180ce08434b96ed17db4975ab9723c6b5fbcc89609  scipy/ndimage/LICENSE.txt
>  sha256  3df9207af2fdb861af0ae3b22026f163b9bcfab4e525dc4943afe2ffa3f77624  scipy/optimize/tnc/LICENSE
>  sha256  f0cedf52503b2d42b83411a0a16e6fefac346dfad8fddc66f50050150123470c  scipy/sparse/linalg/_dsolve/SuperLU/License.txt
> -sha256  0926566f9f406178d1214f8cc796e166b1213dd7c05e0c5b461a8b8ac9e50bbe  scipy/sparse/linalg/_eigen/arpack/ARPACK/COPYING
>  sha256  106d55c931fd6a84822e5345d900273d059f1c27310d02567ccb313c5d18c55d  scipy/spatial/COPYING_QHULL.txt
> diff --git a/package/python-scipy/python-scipy.mk b/package/python-scipy/python-scipy.mk
> index 8c536df130..e6e87d0cb8 100644
> --- a/package/python-scipy/python-scipy.mk
> +++ b/package/python-scipy/python-scipy.mk
> @@ -19,7 +19,6 @@ PYTHON_SCIPY_LICENSE_FILES = \
>  	scipy/ndimage/LICENSE.txt \
>  	scipy/optimize/tnc/LICENSE \
>  	scipy/sparse/linalg/_dsolve/SuperLU/License.txt \
> -	scipy/sparse/linalg/_eigen/arpack/ARPACK/COPYING \

But shouldn't the <pkg>_LICENSE variable be updated?

It contains:

PYTHON_SCIPY_LICENSE = \
        BSD-3-Clause, \
        BSD-2-Clause, \
        BSD, \
        BSD-Style, \
        MIT, \
        Qhull

and I'm wondering if this "BSD" wasn't just for this ARPACK thing?

Also, would be ideal if your commit message for fixes could contain:

Fixes: <commit hash> ("<commit title>")

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-10-03 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 16:07 [Buildroot] [PATCH 1/2] package/python-scipy: remove license file Bernd Kuhls
2026-10-03 16:07 ` [Buildroot] [PATCH v2 2/2] package/python-scipy: bump version to 1.18.1 Bernd Kuhls
2026-10-03 16:15 ` Thomas Petazzoni via buildroot [this message]
     [not found] ` <asEp-UvwtZnTyfY9__33610.5728916422$1791044172$gmane$org@windsurf>
     [not found]   ` <pan$688e1$f7d25450$3dd59207$f0732914@ID-313208.user.individual.net>
2026-10-03 18:40     ` [Buildroot] [PATCH 1/2] package/python-scipy: remove license file Fiona Klute via buildroot
2026-10-03 18:59       ` Fiona Klute via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asEp-UvwtZnTyfY9@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=guillaume.bressaix@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox