Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: buildroot@buildroot.org,
	Meena Murthy <meena.murthy@amarulasolutions.com>,
	James Hilliard <james.hilliard1@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/2] boot/uboot: make binman dependency on host-python-pkg-resources optional
Date: Sun, 25 Oct 2026 15:01:05 +0100	[thread overview]
Message-ID: <at4LLnOcAa5j3RdB@windsurf> (raw)
In-Reply-To: <20261024215330.2067282-1-fiona.klute@gmx.de>

Hello,

Some very weak/minor suggestion below. Honestly not super important.

On Sat, Oct 24, 2026 at 11:53:29PM +0200, Fiona Klute wrote:
> +if BR2_TARGET_UBOOT_USE_BINMAN
> +
> +config BR2_TARGET_UBOOT_BINMAN_NEEDS_PKG_RESOURCES

I would prefer: BR2_TARGET_UBOOT_BINMAN_NEEDS_HOST_PYTHON_PKG_RESOURCES

> +	bool "Binman needs pkg-resources (U-Boot version < 2025.10)"

And here:

    bool "binman needs host-python-pkg-resources"

i.e:

- not uppercase binman
- mention the full package name instead of just pkg-resources
- keep the U-Boot < 2025.10 info in the help text only

> +	depends on BR2_TARGET_UBOOT_USE_BINMAN

"depends on" redundant with the fact that we are inside a "if
BR2_TARGET_UBOOT_USE_BINMAN...endif" block.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-10-25 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 21:53 [Buildroot] [PATCH v2 1/2] boot/uboot: make binman dependency on host-python-pkg-resources optional Fiona Klute via buildroot
2026-10-24 21:53 ` [Buildroot] [PATCH v2 2/2] configs/engicam_px30_core_defconfig: require pkg_resources for binman Fiona Klute via buildroot
2026-10-25 14:01 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at4LLnOcAa5j3RdB@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=james.hilliard1@gmail.com \
    --cc=meena.murthy@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox