Re: [Buildroot] [PATCH 1/1] package/lmbench: bump version

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Sat, Jun 20, 2026 at 03:36:04PM +0200, Bernd Kuhls wrote:
> Removed patches 0005-0012 which are included in this bump.
> 
> Added patches 0005-0007 to fix build errors with older toolchains as
> detected by the Gitlab pipelines.
> 
> Fixes:
> https://autobuild.buildroot.net/results/f9b/f9b22be910361f0a9f020831c6e960cbf21289da/

Since when does the build issue exists? Do we need to backport this
version bump to some LTS branches?

If the problem is solved thanks to your "unused" parameters patches,
why aren't those patches added separately from the version bump?

> or1k:
> lat_mem_pingpong.c: Assembler messages:
> lat_mem_pingpong.c:130: Error: unrecognized instruction `nop'
> 
> bw_mem64d.c: Assembler messages:
> bw_mem64d.c:154: Error: unrecognized instruction `nop'

To solve this, I think (but I am not 100% sure), we could use:

__asm__ __volatile__("": : :"memory")

which is how barrier() is defined in the kernel, to avoid
compiler-level optimizations.

> diff --git a/package/lmbench/0005-src-lat_sig.c-fix-build-with-gcc-9.x.patch b/package/lmbench/0005-src-lat_sig.c-fix-build-with-gcc-9.x.patch
> new file mode 100644
> index 0000000000..087d9e8ae7
> --- /dev/null
> +++ b/package/lmbench/0005-src-lat_sig.c-fix-build-with-gcc-9.x.patch
> @@ -0,0 +1,48 @@
> +From d4ba47cef388acb3a91eb39de4d9329a3810f140 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd@kuhls.net>
> +Date: Sat, 20 Jun 2026 14:35:32 +0200
> +Subject: [PATCH] src/lat_sig.c: fix build with gcc 9.x
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +lat_sig.c: In function ‘handler’:
> +lat_sig.c:23:1: error: parameter name omitted
> + void handler(int) { }
> +
> +lat_sig.c: In function ‘prot’:
> +lat_sig.c:72:1: error: parameter name omitted
> + prot(int) {
> +
> +Upstream: https://github.com/intel/lmbench/pull/60

I think you got some useful feedback on this PR, can you follow-up?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot