Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org, Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH v2] package/eigen: bump to version 5.0.1
Date: Thu, 22 Oct 2026 17:32:12 +0200	[thread overview]
Message-ID: <atosMGtvgeKhEChh@windsurf> (raw)
In-Reply-To: <20260408062831.8587-1-chakrabortyshubham66@gmail.com>

On Wed, Apr 08, 2026 at 11:58:31AM +0530, Shubham Chakraborty wrote:
> Update Eigen from 3.4.0 to 5.0.1.
> 
> Remove the downstream CMake patch because the BLAS, LAPACK and
> CMake package toggles are now provided upstream in 5.0.1.
> 
> Refresh the source and license hashes to match the new release and
> update the package license metadata to reflect the current upstream
> licensing files.
> 
> Add a gcc >= 5 dependency in Config.in because Eigen 5.x requires
> C++14 support.

Actually a dependency on gcc >= 6.x was needed. Eigen "built" fine
with gcc 5, but eigen being a header-only library, it doesn't build
anything. However, gtkiostream would definitely not build with gcc 5.x
using the updated eigen. So I increased the dependency to be gcc >= 6
and applied.

> 
> Update the project homepage to the current upstream GitLab URL.
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> -----------

This should have been just 3 dashes, i.e "---" in order to be
understood by Git as "what follows isn't part of the commit message".

Thanks!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-10-22 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04 10:01 [Buildroot] [PATCH] package/eigen: bump to version 5.0.1 Shubham Chakraborty
2026-04-07 19:39 ` Julien Olivain via buildroot
2026-04-08  6:16   ` Shubham Chakraborty
2026-04-08  6:28 ` [Buildroot] [PATCH v2] " Shubham Chakraborty
2026-10-22 15:32   ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atosMGtvgeKhEChh@windsurf \
    --to=buildroot@buildroot.org \
    --cc=chakrabortyshubham66@gmail.com \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox