From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/zlog: bump to version 1.2.20 and switch to the CMake build
Date: Thu, 22 Oct 2026 23:45:41 +0200 [thread overview]
Message-ID: <atqD_rfy-x1S0X7A@windsurf> (raw)
In-Reply-To: <20261008075224.3992252-1-yegorslists@googlemail.com>
On Thu, Oct 08, 2026 at 09:52:24AM +0200, Yegor Yefremov via buildroot wrote:
> zlog ships two build systems: the hand written makefiles used so far and
> a CMake one, which 1.2.19 reworked. Switch to the latter and use the
> cmake-package infrastructure, because the CMake build not only installs
> zlog.pc like the makefiles do, but also the CMake package files
> (zlogConfig.cmake and friends), so that dependent packages can use
> find_package(zlog) and the zlog::zlog imported target.
>
> Dropping the custom build and install commands also restores the ability
> to build zlog in parallel, as the makefile build had to be serialized
> with MAKE1.
>
> An out of source build is needed, as zlog rejects an in source one since
> 1.2.19: CMake would generate its own makefiles over the hand written
> ones that are part of the source tree.
>
> -DZLOG_WERROR=OFF disables the -Werror upstream turns on by default,
> following the usual Buildroot practice of not letting a new compiler
> warning break the build.
>
> zlog uses C11 atomics since 1.2.19, and 1.2.20 adds 64-bit ones, which
> need libatomic on e.g. ARMv5:
>
> libzlog.so.1.2.20: undefined reference to `__atomic_store_8'
>
> So depend on BR2_TOOLCHAIN_HAS_ATOMIC and link the library against
> libatomic when the toolchain provides it.
>
> The CMake build installs the same set of files as the makefile build did
> (zlog.h, zlog-chk-conf, libzlog.so.1.2.20 and libzlog.a) plus zlog.pc
> and the CMake package files. The soname is libzlog.so.1.2 with either
> build system.
>
> Changelog: https://github.com/HardySimpson/zlog/blob/1.2.20/Changelog
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Applied to master, thanks!
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-10-22 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 7:52 [Buildroot] [PATCH] package/zlog: bump to version 1.2.20 and switch to the CMake build Yegor Yefremov via buildroot
2026-10-22 21:45 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atqD_rfy-x1S0X7A@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox