Re: [Buildroot] [PATCH v2 1/3] package/librdkafka: add new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Sun, Mar 08, 2026 at 09:12:10AM +0100, Thomas Devoogdt wrote:
> diff --git a/package/librdkafka/Config.in b/package/librdkafka/Config.in
> new file mode 100644
> index 00000000000..54380e2d6e0
> --- /dev/null
> +++ b/package/librdkafka/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_LIBRDKAFKA
> +	bool "librdkafka"
> +	depends on !BR2_m68k_cf # assembler "out of range" error

Minor nit: this architecture dependency...

> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_LZ4
> +	help
> +	  librdkafka is a C library implementation of the
> +	  Apache Kafka protocol, providing Producer, Consumer
> +	  and Admin clients.
> +
> +	  https://github.com/confluentinc/librdkafka
> +
> +comment "librdkafka needs a toolchain w/ threads"

... should have been replicated here.

> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Other than that, the series looked good to me, so: whole series
applied to master. Thanks, and sorry for the delay!

Perhaps one concerning issue though is that none of your patches
submitted upstream have been reviewed/merged. But oh well, maybe they
are as slow as we are in Buildroot :/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot