From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dovecot: fix build with LibreSSL
Date: Wed, 4 Nov 2026 23:34:14 +0100 [thread overview]
Message-ID: <auuy04ugIUfC7nkF@windsurf> (raw)
In-Reply-To: <audouIxxR5_vsJNX@windsurf>
Hello Bernd,
On Sun, Nov 01, 2026 at 05:30:26PM +0100, Thomas Petazzoni via buildroot wrote:
> > + static void test_xd_keypair(struct dcrypt_keypair *pair)
> > + {
> > +@@ -2339,7 +2340,9 @@ int main(void)
> > + test_static_verify_ecdsa_x962,
> > + #ifdef HAVE_X25519
> > + test_sign_verify_ed25519,
> > ++#ifndef LIBRESSL_VERSION_NUMBER
> > + test_sign_verify_ed448,
> > ++#endif
>
> So this patch changes test_sign_verify_ed448() so that the function is
> not implemented nor used when LIBRESSL_VERSION_NUMBER is defined.
>
> > +diff --git a/src/lib-dcrypt/test-crypto.c b/src/lib-dcrypt/test-crypto.c
> > +index 6ed164c0f0..20371cefc5 100644
> > +--- a/src/lib-dcrypt/test-crypto.c
> > ++++ b/src/lib-dcrypt/test-crypto.c
> > +@@ -2007,7 +2007,7 @@ static void test_static_verify_ed448(void)
> > + test_end();
> > + }
> > +
> > +-#ifndef LIBRESSL_VERSION_NUMBER
> > ++#ifdef SN_ED448
>
> But then here this gets changed so that the function is now defined
> when SN_ED448 is available... but why isn't this also changed in
> test_xd_keypair() ?
Any feedback on those questions?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-11-04 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 8:25 [Buildroot] [PATCH 1/1] package/dovecot: fix build with LibreSSL Bernd Kuhls
2026-11-01 16:30 ` Thomas Petazzoni via buildroot
2026-11-04 22:34 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auuy04ugIUfC7nkF@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox