From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org,
Angelo Compagnucci <angelo.compagnucci@gmail.com>
Subject: Re: [Buildroot] [PATCH v3 1/6] package/mender-update-modules: add banner module
Date: Thu, 5 Nov 2026 08:31:51 +0100 [thread overview]
Message-ID: <auwwYVD-_tyAv3vL@windsurf> (raw)
In-Reply-To: <20261028113331.2960539-1-adam.duskett@amarulasolutions.com>
Hello Adam,
On Wed, Oct 28, 2026 at 12:33:26PM +0100, Adam Duskett wrote:
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> v2 -> v3: Fixed github link [Thomas]
Thanks for this v3, I've applied patches 1 to 5 to master. I haven't
applied patch 6 as I have questions about it, I'll reply to it
separately.
A quick suggestion: when you send an updated version (like this v3)
which had comments from someone, don't hesitate to add this reviewer
in Cc: of the new iteration. Indeed, in the overwhelming stream of
incoming patches, I can very easily miss that someone is sending a new
iteration of something I looked at before. If you Cc: me on the new
iteration when I've reviewed a previous one, then there's a much
bigger chance I'll have a look at it quickly and apply. It's not a
hard rule/requirement, just a suggestion that can potentially help.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-11-05 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 11:33 [Buildroot] [PATCH v3 1/6] package/mender-update-modules: add banner module Adam Duskett
2026-10-28 11:33 ` [Buildroot] [PATCH v3 2/6] board/mender/x86_64/readme.txt: fix documentation Adam Duskett
2026-10-28 11:33 ` [Buildroot] [PATCH v3 3/6] board/mender/x86_64: add a udev rule to create /dev/root Adam Duskett
2026-10-28 11:33 ` [Buildroot] [PATCH v3 4/6] test_mender/post-build.sh: use /etc/mender/device_type Adam Duskett
2026-10-28 11:33 ` [Buildroot] [PATCH v3 5/6] package/mender: bump to version 5.2.0 Adam Duskett
2026-10-28 14:23 ` Adam Duskett
2026-10-28 11:33 ` [Buildroot] [PATCH v3 6/6] package/mender-connect: depend on mender, drop sysvinit file Adam Duskett
2026-11-05 7:33 ` Thomas Petazzoni via buildroot
2026-11-05 7:31 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auwwYVD-_tyAv3vL@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=angelo.compagnucci@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox