public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Andreas Ziegler <br025@umbiko.net>
To: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Cc: buildroot@buildroot.org, thomas.petazzoni@bootlin.com,
	romain.naour@gmail.com
Subject: Re: [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config
Date: Sun, 29 Mar 2026 06:33:35 +0000	[thread overview]
Message-ID: <b0b5f8952025479230650c07ddf30c76@umbiko.net> (raw)
In-Reply-To: <20260328074708.98982-1-chakrabortyshubham66@gmail.com>

Hi Shubham,

Thank you!

On 2026-03-28 07:47, Shubham Chakraborty wrote:
> The ICU library requires C++ standard library when linking statically.
> Without this, applications using pkg-config --libs --static icu-uc
> will fail to link with undefined reference errors to C++ symbols.
> 
> This patch extends the existing fix for static linking to also add
> -lstdc++ to the Libs field in the pkg-config file when building
> in static-only mode (ENABLE_SHARED is not set).
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>  .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 

Acked-by: Andreas Ziegler <br025@umbiko.net>

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-03-29  6:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 16:28 [Buildroot] [PATCH] package/icu: fix static linking with icu-uc for musl static toolchains Shubham Chakraborty
2026-03-03 18:21 ` [Buildroot] [PATCH v2] " Shubham Chakraborty
2026-03-26 11:36   ` [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc Shubham Chakraborty
2026-03-27  4:27     ` Andreas Ziegler
2026-03-27  9:50       ` Shubham Chakraborty
2026-03-27  9:43     ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty
2026-03-28  5:30       ` Andreas Ziegler
2026-03-28  8:16         ` Shubham Chakraborty
2026-03-28  7:47       ` [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config Shubham Chakraborty
2026-03-29  6:33         ` Andreas Ziegler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0b5f8952025479230650c07ddf30c76@umbiko.net \
    --to=br025@umbiko.net \
    --cc=buildroot@buildroot.org \
    --cc=chakrabortyshubham66@gmail.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox