Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Julien Olivain via buildroot <buildroot@buildroot.org>,
	Dick Olsson <hi@senzilla.io>
Subject: Re: [Buildroot] [PATCH 1/1] boot/edk2: add a new Kconfig option to pass arbitrary build options
Date: Sun, 04 Jan 2026 14:52:26 +0100	[thread overview]
Message-ID: <b30f24b92b5fe6941f7cd048cea58924@free.fr> (raw)
In-Reply-To: <20260104115644.35a50066@windsurf>

Hi Thomas,

On 04/01/2026 11:56, Thomas Petazzoni wrote:
> On Mon, 30 Jun 2025 20:58:54 +0200
> Julien Olivain via buildroot <buildroot@buildroot.org> wrote:
> 
>> EDK2 build may include extra options. Those are usually in the form
>> of "-D SOMEFLAG_ENABLE" and might be specific for a processor
>> architecture or a platform. For example:
>> "-D NETWORK_HTTP_BOOT_ENABLE", "-D NETWORK_TLS_ENABLE", ...
>> 
>> Those options are generally documented in their respective packages.
>> See for example:
>> https://github.com/tianocore/edk2/blob/master/OvmfPkg/README
>> 
>> This commit adds a new Kconfig string option to let the use define
>> arbitrary build flags.
>> 
>> Signed-off-by: Julien Olivain <ju.o@free.fr>
> 
> Sounds good to me, but one question:
> 
>>  EDK2_BUILD_OPTS += \
>> +	$(call qstrip,$(BR2_TARGET_EDK2_EXTRA_BUILD_OPTS)) \
> 
> Shouldn't this go...
> 
>>  	-t GCC5 \
>>  	-n $(BR2_JLEVEL) \
>>  	-a $(EDK2_ARCH) \
> 
> ... at the end of all options, so that BR2_TARGET_EDK2_EXTRA_BUILD_OPTS
> can potentially be used to override whatever option is passed by 
> Buildroot?

I agree this would be better. I've sent a v2 including your suggestion:
https://patchwork.ozlabs.org/project/buildroot/patch/20260104134755.1786447-1-ju.o@free.fr/

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-01-04 13:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 18:58 [Buildroot] [PATCH 1/1] boot/edk2: add a new Kconfig option to pass arbitrary build options Julien Olivain via buildroot
2025-07-05 21:32 ` Romain Naour via buildroot
2026-01-04 10:57   ` Thomas Petazzoni via buildroot
2026-01-04 10:56 ` Thomas Petazzoni via buildroot
2026-01-04 13:52   ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b30f24b92b5fe6941f7cd048cea58924@free.fr \
    --to=buildroot@buildroot.org \
    --cc=hi@senzilla.io \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox