Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org, thomas.petazzoni@bootlin.com
Subject: Re: [Buildroot] [PATCH RESEND] config: add socfpga_agilex5_defconfig
Date: Mon, 9 Nov 2026 14:52:50 -0600	[thread overview]
Message-ID: <b66d9576-ffa7-4ae1-829b-dd3a5637350d@kernel.org> (raw)
In-Reply-To: <da925ae9b0bd1ec41451bd9a38684b1f@free.fr>

Hi Julien,

On 10/29/26 16:30, Julien Olivain wrote:
> Hi Dinh,
> 
> Thanks for the patch. I have few comments.
> 
> Since this defconfig uses "vendor" uboot, TF-A and kernel, I suggest
> to rename it to socfpga_agilex5_vendor_defconfig, to follow the "new"
> convention described in:
> https://elinux.org/Buildroot:DeveloperDaysELCE2024#Rules_for_defconfigs
> 
> Also, to follow the convention in Buildroot, could you change the
> commit title to:
> 
> configs/socfpga_agilex5_vendor: new defconfig
> 
> On 28/10/2026 19:42, Dinh Nguyen via buildroot wrote:
>> Build Linux, U-Boot, and TF-A for the Agilex 5 SoC Development Kit
>> from the QPDS 26.1.1 GSRD sources.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>> ---

[snip]

>> +BR2_PACKAGE_HOST_MTOOLS=y
>> -- 
>> 2.42.0.411.g813d9a9188
> 
> Could you send a v2 addressing those comments, please?
> 
> After those changes, please also make sure the
> the defconfig is regenerated with "make savedefconfig"
> and "utils/docker-run make check-package" does not report
> errors. Thanks.
> 

Thank you for the review. I have addressed your comments and sent out a v2.

Thanks,
Dinh

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-11-09 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 18:42 [Buildroot] [PATCH RESEND] config: add socfpga_agilex5_defconfig Dinh Nguyen via buildroot
2026-10-29 21:30 ` Julien Olivain via buildroot
2026-11-09 20:52   ` Dinh Nguyen via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b66d9576-ffa7-4ae1-829b-dd3a5637350d@kernel.org \
    --to=buildroot@buildroot.org \
    --cc=dinguyen@kernel.org \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox